Skip to content

Send list-valued query parameters on reads (unblocks YouTube) - #160

Merged
sykosyber merged 1 commit into
mainfrom
wp/omni/list-query-params
Oct 13, 2026
Merged

sykosyber merged 1 commit into
mainfrom
wp/omni/list-query-params

Conversation

@sykosyber

Copy link
Copy Markdown
Member

Objective. Unblock YouTube's list operations, which all require part, a list-valued query parameter (found while rebuilding the index, #159).

What changed

  • openapi.ts: a query parameter whose schema is an array of plain values (string, number, integer, boolean), with style form or unset and explode not false, compiles on GET/HEAD, required or optional. On reads, an optional parameter whose name cannot be an input (Google's $.xgafv) is left out rather than refusing the operation (isInputName exported from manifest.ts).
  • httpTarget.ts: isPlainList, and setQueryParam, which repeats the name once per element. Used by the browser runtime (execute.ts, so the run preview shows the same URL) and the broker (capabilityBroker.ts).
  • CapabilityInputs.tsx: a plain list is a one-line field taking comma-separated text (snippet, statistics) or a JSON array. Empty text means no value.

What did not change. Writes: any compound parameter, or an unnamed-able one, still refuses a POST/PUT/PATCH/DELETE, so no new write surface (AGENTS.md stop condition 3). Comma-joined lists (explode: false), lists of objects, and header lists are still refused. No manifest field was added, so existing digests are unchanged. public/api-index.json is not rebuilt here (after the next package, so one rebuild counts both).

Tests run

  • npm run typecheck 0 errors; npm run lint 0 errors (8 existing warnings).
  • npm test: 1636 passed, 1 failed (fieldHarness.test.ts, the known Windows-only CRLF failure).
  • New listQueryParameters.test.ts (8): compile accept/refuse cases (explode false, list of objects, write), repeated serialization, browser preview URL and executed request, broker request, comma-separated entry and empty text. compoundParameters.test.ts updated: its two list fixtures now use shapes that remain unsupported, plus 2 cases for $.xgafv.
  • npm run build + npm run scan:bundle PASS; npm run build:next + npm run test:e2e 9 passed.

Measurements. Compiling the real YouTube Data v3 spec (APIs.guru): 0 → 18 operations, all list reads, all bound to youtube.readonly except thirdPartyLinks.list, which declares no sign-in. The 4 remaining part refusals are writes.

Known failures. fieldHarness.test.ts on Windows only.

Claim ceiling. Implemented and tested with fixtures. No YouTube call made (no OAuth client registered).

Architectural decisions introduced. Query lists are sent exploded only, the OpenAPI default, so the manifest needs no serialization field.

Evidence that could falsify it. An API that declares a default-style query list but rejects repeated names. A compiled write manifest carrying a list or a skipped parameter.

Next permissible package. Untyped nested output properties (Calendar events.list), then one npm run catalog:build.

🤖 Generated with Claude Code

A query parameter that is a list of plain values (strings, numbers,
booleans), sent the OpenAPI default way (form, exploded: part=a&part=b),
now compiles on a GET or HEAD, required or not. The browser runtime and the
broker both repeat the name once per element. The block takes it as
comma-separated text ("snippet, statistics") or a JSON array.

Also on reads: an optional parameter whose name cannot be an input (Google's
`$.xgafv`) is left out instead of refusing the operation.

Writes are unchanged: any compound parameter still refuses a write
(AGENTS.md stop condition 3). Comma-joined lists (explode: false) and lists
of objects are still refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sykosyber
sykosyber enabled auto-merge October 13, 2026 02:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T03:04:51.364378Z 3ad8817 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sykosyber
sykosyber merged commit db4ae5e into main Oct 13, 2026
4 checks passed
@sykosyber
sykosyber deleted the wp/omni/list-query-params branch October 13, 2026 03:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ad8817d6c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/capabilities/httpTarget.ts Resolved
Comment thread src/core/capabilities/httpTarget.ts Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant