Repository navigation
Send list-valued query parameters on reads (unblocks YouTube) - #160
Merged
Merged
Conversation
A query parameter that is a list of plain values (strings, numbers,
booleans), sent the OpenAPI default way (form, exploded: part=a&part=b),
now compiles on a GET or HEAD, required or not. The browser runtime and the
broker both repeat the name once per element. The block takes it as
comma-separated text ("snippet, statistics") or a JSON array.
Also on reads: an optional parameter whose name cannot be an input (Google's
`$.xgafv`) is left out instead of refusing the operation.
Writes are unchanged: any compound parameter still refuses a write
(AGENTS.md stop condition 3). Comma-joined lists (explode: false) and lists
of objects are still refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sykosyber
enabled auto-merge
October 13, 2026 02:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ad8817d6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective. Unblock YouTube's list operations, which all require
part, a list-valued query parameter (found while rebuilding the index, #159).What changed
openapi.ts: a query parameter whose schema is an array of plain values (string, number, integer, boolean), with styleformor unset andexplodenot false, compiles on GET/HEAD, required or optional. On reads, an optional parameter whose name cannot be an input (Google's$.xgafv) is left out rather than refusing the operation (isInputNameexported frommanifest.ts).httpTarget.ts:isPlainList, andsetQueryParam, which repeats the name once per element. Used by the browser runtime (execute.ts, so the run preview shows the same URL) and the broker (capabilityBroker.ts).CapabilityInputs.tsx: a plain list is a one-line field taking comma-separated text (snippet, statistics) or a JSON array. Empty text means no value.What did not change. Writes: any compound parameter, or an unnamed-able one, still refuses a POST/PUT/PATCH/DELETE, so no new write surface (AGENTS.md stop condition 3). Comma-joined lists (
explode: false), lists of objects, and header lists are still refused. No manifest field was added, so existing digests are unchanged.public/api-index.jsonis not rebuilt here (after the next package, so one rebuild counts both).Tests run
npm run typecheck0 errors;npm run lint0 errors (8 existing warnings).npm test: 1636 passed, 1 failed (fieldHarness.test.ts, the known Windows-only CRLF failure).listQueryParameters.test.ts(8): compile accept/refuse cases (explode false, list of objects, write), repeated serialization, browser preview URL and executed request, broker request, comma-separated entry and empty text.compoundParameters.test.tsupdated: its two list fixtures now use shapes that remain unsupported, plus 2 cases for$.xgafv.npm run build+npm run scan:bundlePASS;npm run build:next+npm run test:e2e9 passed.Measurements. Compiling the real YouTube Data v3 spec (APIs.guru): 0 → 18 operations, all list reads, all bound to
youtube.readonlyexceptthirdPartyLinks.list, which declares no sign-in. The 4 remainingpartrefusals are writes.Known failures.
fieldHarness.test.tson Windows only.Claim ceiling. Implemented and tested with fixtures. No YouTube call made (no OAuth client registered).
Architectural decisions introduced. Query lists are sent exploded only, the OpenAPI default, so the manifest needs no serialization field.
Evidence that could falsify it. An API that declares a default-style query list but rejects repeated names. A compiled write manifest carrying a list or a skipped parameter.
Next permissible package. Untyped nested output properties (Calendar
events.list), then onenpm run catalog:build.🤖 Generated with Claude Code