Skip to content

Codex: repeat query lists only on reads; refuse an empty required list - #162

Merged
sykosyber merged 1 commit into
mainfrom
wp/omni/list-query-fixes
Oct 13, 2026
Merged

sykosyber merged 1 commit into
mainfrom
wp/omni/list-query-fixes

Conversation

@sykosyber

Copy link
Copy Markdown
Member

Objective. Fix the two Codex findings on #160 (merged before review finished).

What changed

What did not change. Read behavior from #160; compile rules.

Tests run. typecheck 0 errors; lint 0 errors (8 existing warnings); npm test 1638 passed, 1 failed (fieldHarness.test.ts, known Windows-only CRLF). listQueryParameters.test.ts: + non-read effects keep one JSON value; + empty required list refused with no request sent.

Measurements. None. Known failures. fieldHarness on Windows only. Claim ceiling. Tested with fixtures. Architectural decisions introduced. List serialization depends on the manifest's effect.

Evidence that could falsify it. A write request carrying a repeated query name.

Next permissible package. Catalog rebuild after #161.

🤖 Generated with Claude Code

… list

Writes and computes keep sending one JSON value for a list, as they did
before #160, so no write path changes. A required query list given as []
is INPUT_INVALID instead of being left out of the request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sykosyber
sykosyber enabled auto-merge October 13, 2026 03:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T03:13:08.288603Z 385e830 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sykosyber
sykosyber merged commit f12bf5a into main Oct 13, 2026
4 checks passed
@sykosyber
sykosyber deleted the wp/omni/list-query-fixes branch October 13, 2026 03:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 385e830f1b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

export function setQueryParam(params: URLSearchParams, name: string, value: unknown): void {
if (Array.isArray(value)) {
export function setQueryParam(params: URLSearchParams, name: string, value: unknown, effect: CapabilityEffect): void {
if (Array.isArray(value) && effect === 'read') {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve exploded lists for GET compute capabilities

A GET or HEAD operation explicitly marked x-omni-effect: compute is still accepted by collectInputs with a plain exploded query list and is eligible for the broker, but this condition serializes that list as one JSON value rather than the OpenAPI name=a&name=b form. Consequently, any such valid manifest sends a different request than before this commit (for example tags=%5B%22a%22%2C%22b%22%5D), which breaks endpoints that require exploded list parameters. Base the list encoding on the HTTP method/supported parameter shape, or retain repeated encoding for compute GET/HEAD capabilities.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant