Skip to content

Compiler: leave out an optional compound query or header parameter - #157

Merged
sykosyber merged 3 commits into
mainfrom
wp/omni/optional-compound-params
Oct 12, 2026
Merged

sykosyber merged 3 commits into
mainfrom
wp/omni/optional-compound-params

Conversation

@sykosyber

@sykosyber sykosyber commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Objective. Stop refusing a whole operation because of an optional parameter Flyspace cannot send. Found while building Connect (#156): Google Calendar events.list was refused for its optional eventTypes array.

What changed. collectInputs in src/core/capabilities/openapi.ts: an optional array/object query or header parameter of a GET or HEAD operation is skipped; a required one, or any on a write, still refuses the operation with the same message, so no new write surface compiles (AGENTS.md stop condition 3; Codex finding, fixed in 4f34c68). New compoundParameters.test.ts (4).

What did not change. Path and body handling. Required compound parameters. public/api-index.json is not rebuilt here (next package, after #156, so one rebuild counts both).

Tests run. npm run typecheck 0 errors; npm run lint 0 errors (8 existing warnings); npm test 1597 passed, 1 failed (fieldHarness.test.ts, known Windows-only CRLF failure). No existing test depended on the old refusal.

Measurements. None yet; the catalog rebuild will count how many directory operations this unblocks.

Known failures. fieldHarness.test.ts on Windows only.

Claim ceiling. Implemented and tested with fixtures.

Architectural decisions introduced. A parameter the compiler cannot represent is dropped when optional, not fatal. The person loses that filter, not the operation.

Evidence that could falsify it. An API that rejects a request without a parameter it declared optional. That would be a spec error, but it would show as an HTTP 400 on the block.

Next permissible package. Rebuild public/api-index.json (npm run catalog:build) once this and #156 are on main.

🤖 Generated with Claude Code

An optional array or object query/header parameter used to refuse the whole
operation. It is now left out of the inputs, and the operation compiles: it
works without that parameter (Google Calendar's events.list and eventTypes).
A required compound parameter still refuses the operation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sykosyber
sykosyber enabled auto-merge October 12, 2026 23:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T23:12:27.453212Z 1a78042 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a78042bd6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/capabilities/openapi.ts Resolved
Comment thread src/core/capabilities/openapi.ts Resolved
sykosyber and others added 2 commits October 12, 2026 16:13
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…conversion failure

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Oct 12, 2026

Copy link
Copy Markdown

Correction: the commit cited as 1b92eb5 in the thread replies was rebased; it is 14b738f. The first finding (GET/HEAD only) was already fixed in 4f34c68; 14b738f adds the skip of unconvertible optional compound params on reads.

@github-actions

Copy link
Copy Markdown
Contributor

Codex feedback round 1 answered 2 of 2 Codex finding(s).

@sykosyber
sykosyber merged commit 589e1d9 into main Oct 12, 2026
4 checks passed
@sykosyber
sykosyber deleted the wp/omni/optional-compound-params branch October 12, 2026 23:17
sykosyber added a commit that referenced this pull request Oct 12, 2026
Catalog: rebuild the API index after Connect (#156) and #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant