Repository navigation
Compiler: leave out an optional compound query or header parameter - #157
Conversation
An optional array or object query/header parameter used to refuse the whole operation. It is now left out of the inputs, and the operation compiles: it works without that parameter (Google Calendar's events.list and eventTypes). A required compound parameter still refuses the operation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a78042bd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…conversion failure Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Codex feedback round 1 answered 2 of 2 Codex finding(s). |
Objective. Stop refusing a whole operation because of an optional parameter Flyspace cannot send. Found while building Connect (#156): Google Calendar
events.listwas refused for its optionaleventTypesarray.What changed.
collectInputsinsrc/core/capabilities/openapi.ts: an optional array/objectqueryorheaderparameter of a GET or HEAD operation is skipped; a required one, or any on a write, still refuses the operation with the same message, so no new write surface compiles (AGENTS.md stop condition 3; Codex finding, fixed in 4f34c68). NewcompoundParameters.test.ts(4).What did not change. Path and body handling. Required compound parameters.
public/api-index.jsonis not rebuilt here (next package, after #156, so one rebuild counts both).Tests run.
npm run typecheck0 errors;npm run lint0 errors (8 existing warnings);npm test1597 passed, 1 failed (fieldHarness.test.ts, known Windows-only CRLF failure). No existing test depended on the old refusal.Measurements. None yet; the catalog rebuild will count how many directory operations this unblocks.
Known failures.
fieldHarness.test.tson Windows only.Claim ceiling. Implemented and tested with fixtures.
Architectural decisions introduced. A parameter the compiler cannot represent is dropped when optional, not fatal. The person loses that filter, not the operation.
Evidence that could falsify it. An API that rejects a request without a parameter it declared optional. That would be a spec error, but it would show as an HTTP 400 on the block.
Next permissible package. Rebuild
public/api-index.json(npm run catalog:build) once this and #156 are on main.🤖 Generated with Claude Code