Repository navigation
Codex: compare OAuth state as bytes; document both local callback URIs - #158
Conversation
… URIs A non-ASCII state of the right length in characters made timingSafeEqual throw (500) instead of refusing the sign-in. And localhost and 127.0.0.1 are different origins to Google, so local setup needs both redirect URIs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b38270765
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Codex feedback round 1 answered 1 of 1 Codex finding(s). |
Objective. Fix the two Codex findings on #156 (merged before review finished).
What changed
oauthConnect.ts:stateis compared byte length first, so a non-ASCII state of the same character length is refused instead of throwingRangeError(a 500). The new test reproduced the RangeError before the fix..env.exampleandDEPLOYMENT.md: register a redirect URI for every origin Flyspace is opened at. For local use that means bothhttp://localhost:3000/...andhttp://127.0.0.1:3000/..., because Google matches exactly and the README's default is localhost.What did not change. The flow, scopes, and cookie.
Tests run. typecheck 0 errors; lint 0 errors (8 existing warnings);
npm test1622 passed, 1 failed (fieldHarness.test.ts, known Windows-only CRLF). New:oauthConnect.test.tsnon-ASCII state case.Measurements. None. Known failures. fieldHarness on Windows only. Claim ceiling. Tested with stubs. Architectural decisions introduced. None.
Evidence that could falsify it. A callback request that still answers 500 for a malformed state.
Next permissible package. Catalog rebuild after #157.
🤖 Generated with Claude Code