Fix broken French and Swedish spell-check dictionary URLs (#12267)#12275
Merged
Conversation
LibreOffice moved the .aff/.dic files for fr_FR and sv_SE into a dictionaries/ subfolder, so the download URLs in HunspellDictionaries.json returned 404 and the download silently failed. This affected French, Swedish and Swedish (Finland). Point the 6 affected URLs at the new dictionaries/ subfolder. Verified all 164 dictionary file URLs in the list now resolve (200/206). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #12267. The French spell-check dictionary (and both Swedish variants) could not be downloaded — the download silently failed with "Download failed". The OCR dictionary for French worked because it uses a different source.
Cause
The download list (
src/ui/Assets/HunspellDictionaries.json) points at the LibreOffice dictionaries repo. LibreOffice reorganized thefr_FRandsv_SEfolders, moving the.aff/.dicfiles into adictionaries/subfolder. The old URLs now return 404.Verification
I checked all 89 dictionaries / 164 file URLs in the list via parallel HTTP requests (following redirects). Exactly 3 dictionaries were broken, all for the same reason:
fr_FR/fr.{aff,dic}fr_FR/dictionaries/fr.{aff,dic}sv_SE/sv_SE.{aff,dic}sv_SE/dictionaries/sv_SE.{aff,dic}sv_SE/sv_FI.{aff,dic}sv_SE/dictionaries/sv_FI.{aff,dic}The other 86 dictionaries (161 URLs) all resolve fine — only
fr_FRandsv_SEwere reorganized upstream.Fix
Updated the 6 affected URLs to the new
dictionaries/subfolder. After the change, all 164 URLs resolve (200/206) and the JSON remains valid.🤖 Generated with Claude Code