Add right-to-left option to ASSA karaoke advanced effects (#12271)#12274
Merged
Conversation
The two karaoke advanced effects (character "Karaoke" and word-based "Karaoke - active word pop") assigned the highlight timing in logical order, so for Hebrew/Arabic the highlight progressed visually left-to-right, which is backwards. Add a "Right-to-left" checkbox to both effects that reverses the highlight progression (last character/word first). It is auto-enabled when the subtitle text is detected as a right-to-left language via LanguageAutoDetect.ContainsRightToLeftLetter. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #12271. The two karaoke ASSA advanced effects — character-based Karaoke and word-based Karaoke - active word pop — assign the highlight timing in logical text order. For right-to-left languages (Hebrew, Arabic) the highlight therefore progresses visually left-to-right, which is backwards for the reading direction. Existing RTL features only fix text layout, not the timing sequence.
Change
Add a Right-to-left checkbox to both karaoke effects. When enabled, the highlight progression is reversed so the last character/word is highlighted first — matching right-to-left reading order.
AdvancedEffectKaraoke: reveals the laststep+1characters instead of the first.AdvancedEffectFancyKaraoke(auto word sequencing): advances the active word from the last word towards the first.The checkbox is auto-enabled when the subtitle text is detected as a right-to-left language via
LanguageAutoDetect.ContainsRightToLeftLetter, so RTL subtitles get the correct behavior by default while the user can still toggle it.Notes
Builds clean. The visual result depends on the user's RTL layout setup, so it's best confirmed by opening the effect on a Hebrew/Arabic subtitle in the running app — the checkbox is the requested control to get the progression direction right either way.
🤖 Generated with Claude Code