Fix message box appearing behind undocked audio visualizer (#12268)#12273
Merged
niksedk merged 1 commit intoJul 8, 2026
Merged
Conversation
Message boxes went straight to ShowDialog without the KeepTopmostWhileOwnerActive helper that WindowService.ShowDialogAsync applies, so they opened behind the undocked audio visualizer (and video player), which float on top of the main window. Apply the same helper in MessageBox.Show; since all message boxes funnel through this method, this covers them all at once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #12268. When the audio visualizer is undocked, message boxes appear behind it instead of on top.
Cause
The undocked audio visualizer (and video player) float on top of the main window via
WindowService.KeepTopmostWhileOwnerActive, which setsTopmostwhile the owner or the tool window is active. Regular dialogs go throughWindowService.ShowDialogAsync, which applies the same helper to the dialog so it stays above the floating tool windows (the #11971 fix).But
MessageBox.ShowbypassesWindowService— it constructs the window and callsShowDialog(owner)directly — so message boxes had no such protection and opened behind the undocked audio visualizer.Fix
Apply the same
KeepTopmostWhileOwnerActive(msgBox, owner)call inMessageBox.ShowbeforeShowDialog, matching how the Settings/Shortcuts dialogs are handled. Since every message box in the app funnels through this single static method, this is a systematic fix covering all message boxes at once.🤖 Generated with Claude Code