fix(paths): restrict backslash-to-slash normalization to win32 - #157
Open
Zaldaryon wants to merge 1 commit into
Open
fix(paths): restrict backslash-to-slash normalization to win32#157Zaldaryon wants to merge 1 commit into
Zaldaryon wants to merge 1 commit into
Conversation
On posix, backslash is a legal filename character. The unconditional replacement collapsed dir\x and dir/x into the same normalized string, producing false in-use refusals when both existed. Move the backslash-to-slash replacement inside the win32 branch so posix paths preserve backslash as a literal character. Fixes #155
Pixnop
approved these changes
Aug 19, 2026
Pixnop
left a comment
Pixnop
left a comment
Contributor
There was a problem hiding this comment.
Approving. Probed both directions on the head: the posix pair with a literal backslash in the name now stays distinct, and the win32 mixed-separator detection is preserved. Sixteen tests pass with the updated posix row. That closes the last quirk from the paths module cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On posix, backslash is a legal filename character. The unconditional replacement in
normalizeFolderForComparisoncollapseddir\xanddir/xinto the same normalized string, producing false in-use refusals when both paths existed on a Linux filesystem.This moves the backslash-to-slash replacement inside the win32 branch. Posix paths now preserve backslash as a literal character, and the trailing-separator strip still handles both separators on both platforms.
Test updated to assert the new posix behavior.
Fixes #155