feat: diceware passphrase generation (vault generate --passphrase + TUI)#51
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 tasks
UnbreakableMJ
force-pushed
the
passphrase-generator
branch
from
July 19, 2026 15:44
2ca7cd4 to
3bb3a56
Compare
Add generate_passphrase to vault-core (EFF large wordlist, 7776 words, CC-BY-3.0, vendored at crates/vault-core/src/wordlist.rs), wired through `vault generate --passphrase` and the TUI generator overlay (Tab switches Password<->Passphrase). Preferences persist via a new [generate] config table; generation stays fully client-side, so no secret touches the agent or network. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
UnbreakableMJ
force-pushed
the
passphrase-generator
branch
from
July 19, 2026 15:50
3bb3a56 to
db0228c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_passphrasetovault-core, drawing from the EFF large wordlist (7776 words, CC-BY-3.0, vendored atcrates/vault-core/src/wordlist.rs) with configurable word count (3-20), separator, capitalization, and an optional appended digit.vault generate --passphrase(new flags:--words,--separator,--[no-]capitalize,--[no-]include-number) and the TUI generator overlay (Tabswitches Password⇄Passphrase;+/-adjust count;a/n/etoggle capitalize/number/separator).[generate]config table remembers preferences across sessions; explicit CLI flags override. Generation stays fully client-side — no secret touches the agent or the network.LICENSES/CC-BY-3.0.txt,REUSE.tomlpath override,CREDITS.mdentry, regeneration script atcrates/vault-core/tools/gen_wordlist.sh).Test plan
cargo build --workspace --all-targetsRUSTFLAGS="-D warnings" cargo test --workspace --all-targets(all crates pass, 0 failures)target/clippy,RUSTFLAGS="-D warnings" cargo clippy --workspace --all-targets --all-features -- -D warnings(clean)cargo fmt --all -- --checkvault-cli --no-default-features --features cli,vault-agent --no-default-features)--versionattribution block (version-gate)reuse lint(compliant, CC-BY-3.0 + GPL-3.0-or-later)vault generate --passphrase --words 6 --json,--separator/--capitalize/--include-numbercombinations, and existing--length/--symbolspassword path all verified working🤖 Generated with Claude Code