Skip to content

fix(deps): clear high advisories, drop expired PartyKit exception #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarthakagrawal927 merged 1 commit into from
Oct 3, 2026
Merged

fix(deps): clear high advisories, drop expired PartyKit exception #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@
},
"pnpm": {
"overrides": {
"nanoid@>=3.0.0 <4.0.0": "3.3.18"
"brace-expansion@>=5.0.0 <6.0.0": "5.0.12",
"nanoid@>=3.0.0 <4.0.0": "3.3.18",
"undici@^5.28.4": "6.29.0"
}
}
}
28 changes: 11 additions & 17 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 3 additions & 22 deletions scripts/check-code-health.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,33 +220,14 @@ function checkDependencies() {
const severe = Object.entries(report.advisories ?? {}).filter(
([, advisory]) => ["critical", "high"].includes(advisory.severity)
);
const allowedHigh = new Set(["1114638", "1114640", "1121245"]);
const unexpected = severe.filter(([id]) => !allowedHigh.has(id));
const missing = [...allowedHigh].filter(
(id) => !severe.some(([observedId]) => observedId === id)
);
const reviewDate = new Date("2026-09-12T00:00:00Z");
log(
`Dependencies: ${severe.length} critical/high advisories; ` +
`${severe.length - unexpected.length} accepted PartyKit/Miniflare findings.`
);
if (Date.now() >= reviewDate.getTime()) {
throw new Error(
"PartyKit dependency-risk exception expired on 2026-09-12 (#26)."
);
}
if (unexpected.length > 0) {
log(`Dependencies: ${severe.length} critical/high advisories.`);
if (severe.length > 0) {
throw new Error(
`Unexpected critical/high advisories: ${unexpected
`Critical/high advisories: ${severe
.map(([id, advisory]) => `${id}/${advisory.github_advisory_id}`)
.join(", ")}`
);
}
if (missing.length > 0) {
log(
`Dependency risk improved; remove resolved exceptions: ${missing.join(", ")}.`
);
}
}

function countMatches(pattern) {
Expand Down
Loading