fix(deps): clear high advisories, drop expired PartyKit exception - #40
Merged
Merged
Conversation
The code-health dependency gate has failed since 2026-09-12 when the time-boxed PartyKit/Miniflare Undici exception expired; three more highs (brace-expansion x2, @fastify/busboy) have since appeared. - override undici ^5.28.4 (miniflare 3, via partykit) to 6.29.0, which also drops the vulnerable @fastify/busboy dependency - override brace-expansion 5.x to 5.0.12 (dev, via ultracite) - remove the advisory allowlist and expiry; any critical/high now fails pnpm audit: 0 critical/high (4 moderate). Refs #26. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Code health" job has failed on main since run 35635208148:
quality:dependenciesthrows because the time-boxed PartyKit/Miniflare advisory exception expired on 2026-09-12 (#26). The current audit also shows 3 more high advisories that aren't on the allowlist.undici@^5.28.4→ 6.29.0The gate no longer has an allowlist or expiry date, so any critical/high advisory fails it.
pnpm audit: 0 critical/high, 4 moderate.node scripts/check-code-health.mjs dependenciespasses.Risk: the undici override crosses Miniflare 3's declared
^5.28.4range. It only affects the parked v2 PartyKit relay (server/, used bypnpm run dev), not the v1 on-phone path. The same override is on draft #39, where Miniflare dispatchFetch, redirects and WebSocket echo were checked on Node 20.19. PartyKit's own bundled Undici copy is not covered by this change, and #26 tracks that.Overlaps with draft #39 (same
package.jsonoverrides, except brace-expansion 5.0.12 here vs 5.0.11). #39 will need a trivial rebase.🤖 Generated with Claude Code