Repository navigation
Read the body source after destination allocation - #231
Merged
Merged
Conversation
filter_body reads the source pointer before it converts or resizes the destination. Ruby code or allocation can change the source before the parser uses that pointer. Read the source length after destination conversion. Read the source pointer after destination allocation. Add tests for chunked and fixed-length bodies.
rafaelfranca
marked this pull request as draft
November 18, 2026 22:46
This was referenced Nov 18, 2026
rafaelfranca
marked this pull request as ready for review
November 18, 2026 23:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HttpParser#filter_bodyreads the source pointer before it converts or resizes the destination.Ruby code or allocation can change the source before the parser uses that pointer.
The old pointer can then refer to invalid data.
Solution
Read the source length after destination conversion.
Read the source pointer after the destination changes.
Add a regression test for chunked and fixed-length bodies.
Verification
master, Ragel output matched the checked-in C on x86-64.