Skip to content

Test the checked-in parser before Ragel runs - #234

Merged
rafaelfranca merged 1 commit into
masterfrom
ci-fixes/ci-parser-check
Nov 18, 2026
Merged

rafaelfranca merged 1 commit into
masterfrom
ci-fixes/ci-parser-check

Conversation

@rafaelfranca

@rafaelfranca rafaelfranca commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Problem

The default rake task regenerates the C parser before it runs the tests.
The tests can therefore miss a defect in the C file that the gem includes.

Solution

Compile and test the checked-in C file first.
Run Ragel afterward and check that its output matches the checked-in file.

Verification

The default rake task regenerates the C parser before it runs the tests. This can hide a defect in the C file that the gem includes.

Compile and test the checked-in C file first. Regenerate it afterward to check that it matches the Ragel grammar.
@rafaelfranca
rafaelfranca marked this pull request as draft November 18, 2026 22:46
@rafaelfranca
rafaelfranca marked this pull request as ready for review November 18, 2026 22:47
@rafaelfranca
rafaelfranca merged commit 3c6282f into master Nov 18, 2026
11 of 13 checks passed
@rafaelfranca
rafaelfranca deleted the ci-fixes/ci-parser-check branch November 18, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants