Make Safe archive warming active, bounded and observable - #7
Merged
1 commit merged intoSep 29, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old Safe profile could complete a session with no caching work when archive opens were already buffered. Version 2.2.0 enables paced buffered reads of archives successfully opened by Skyrim, so
patched=0can now accompany positivewarm_read_bytes.Safe keeps executable-only interception and read-only eligibility. Warming has session/per-file/rate/deadline limits, drive-based reductions, memory guards and save-load pauses. Minimal disables warming for comparison. Experimental retains its opt-in wider hook and sampling. Counters distinguish completed reads from mapped requests and discarded diagnostic reads; existing INI opt-outs remain respected.
Validation: Release x64 builds; all 13 local checks pass against the actual DLL and production policy. The unchanged parent completed zero background reads in the same host. Source/archive gates verify version metadata, every ZIP member and all three FOMOD selections. Forge native/FOMOD and Skyrim archive audits pass; the only FOMOD document exemption is the preserved uninstalled package notice. CI repeats the host checks before packaging. Detailed evidence:
docs/VALIDATION-2.2.0.md.This is a draft candidate. In-game performance, full runtime compatibility and actual mod-manager installation remain unmeasured. No public release or game deployment is part of this PR.