[Klaud Cold] [AMD] Bump DSV4 MI355X vLLM 8k/1k to the 2026-09-01 nightly / [Klaud Cold] [AMD] 将 DSV4 MI355X vLLM 8k/1k 更新至 2026-09-01 nightly - #2792
Conversation
Update the fixed-sequence STP and MTP image pins to the 2026-09-01 ROCm nightly. Keep the existing AITER flags because the newly merged DSV4 optimizations auto-enable through that path. 中文:将 MI355X 固定序列 8k/1k 的 DSV4 STP 与 MTP 镜像更新到 2026-09-01 ROCm nightly。保留现有 AITER 标志,新合入的 DSV4 优化会通过该路径自动启用。
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
Claude finished @jiacao-amd's task in 1m 56s —— View job PR Review
LGTM - no blocking issues found. Verification details:
|
There was a problem hiding this comment.
Looks good, straightforward image bump. Reviewed the amd-master.yaml diff (only the two image: tags and their explanatory comments change; concurrency ranges, TP, and scenario fields are untouched) and confirmed the perf-changelog.yaml entry is appended at the tail per the append-only convention, matching the two config keys touched.
Extended reasoning...
Overview
The diff touches only configs/amd-master.yaml and perf-changelog.yaml. In amd-master.yaml, the two dsv4-fp4-mi355x-vllm and dsv4-fp4-mi355x-vllm-mtp entries have their image: field bumped from one ROCm nightly tag to another (both digest-suffixed, per the repo's stated digest-pinning requirement), plus rewritten explanatory comments describing why no new serving flags are needed. No other YAML fields (model, precision, framework, search-space/concurrency ranges, spec-decoding) changed. perf-changelog.yaml gets one new entry appended at the very tail, listing the two config keys, scenario-type, old/new image tags, digest, and a note that existing AITER env vars/flags are unchanged — consistent with AGENTS.md's append-only, byte-sensitive changelog rule.
Security risks
None. This is a version/tag bump in a YAML config plus a changelog entry; no code execution paths, auth, or secrets are touched.
Level of scrutiny
Low. This is exactly the class of change AGENTS.md and the guidelines call out as approvable: a mechanical image-tag bump with matching documentation update, no serving-flag or scenario changes in the YAML body itself. The model.container must equal image rule from AGENTS.md applies only to multi-node srt-slurm recipes, which is not the case here (these entries have no model.container field), so that invariant is inapplicable rather than violated.
Other factors
The bug hunter reported zero findings. I independently verified via git diff that the only body (non-comment) changes are the two image: lines, and that the perf-changelog entry was appended after the prior tail entry (PR #2634) without altering any preceding bytes. No CODEOWNERS check was needed since this is a generic recipe config, and the PR description's claims (digest, upstream vLLM commits) are not independently verifiable from the diff alone, but they don't affect the correctness of the config-file mechanics being reviewed here.
Add shared-expert fusion and INT4 quick-reduce environment variables to the MI355X 8k/1k STP and MTP paths, and document the explicit recipe settings.\n\n中文:为 MI355X 8k/1k 的 STP 与 MTP 路径加入 shared-expert fusion 和 INT4 quick-reduce 环境变量,并同步记录显式启用的配方设置。
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=33478188035 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=33480422577 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=33537691400 |
Reuse the completed full sweep after synchronizing the PR with main. 中文:PR 与 main 同步后复用已完成的完整扫描,跳过重复扫描。
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=33681446902 |
Summary
Update both fixed-sequence DeepSeek-V4-Pro FP4 MI355X vLLM configurations for the 8k/1k workload:
dsv4-fp4-mi355x-vllm(STP)dsv4-fp4-mi355x-vllm-mtp(MTP)Image update:
vllm/vllm-openai-rocm:nightly-09663abde0f50944a8d5ea30120666024b503faavllm/vllm-openai-rocm:nightly-7c5dc571cbd1064ecc8a9b1045637ff647aa22cbsha256:f0bdaf5217a09949842b45c1ea1f12260d3205ec81f143b320dfc2eb3ec95e552026-09-01T05:31:02Z7c5dc571The 8k/1k TP8 concurrency range remains unchanged at 4-512 for both STP and MTP.
vLLM DSV4 optimization review
The new nightly includes the following relevant changes merged after the 2026-08-17 nightly used by #2590:
The newly merged DSV4 kernels are selected automatically through the existing
VLLM_ROCM_USE_AITER=1,VLLM_ROCM_USE_AITER_MOE=1, and--moe-backend aitersettings. For parity with the latest ROCm recipe, both STP and MTP now also set:VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=1. The currentdeepseek-ai/DeepSeek-V4-Procheckpoint exposes FP4 routed experts with an FP8 block-quantized shared-expert path, so the latest vLLM compatibility check self-disables this fusion when the path is not eligible.VLLM_ROCM_QUICK_REDUCE_QUANTIZATION=INT4to enable INT4 quantized quick all-reduce; the full sweep evals cover the accuracy impact.Validation
/home/jiacao/.local/bin/uv run --with 'pydantic>=2' --with pyyaml \ python3 utils/matrix_logic/generate_sweep_configs.py full-sweep \ --config-files configs/amd-master.yaml \ --model-prefix dsv4 \ --framework vllm \ --precision fp4 \ --runner-type mi355x \ --min-conc 4 --max-conc 512 \ --seq-lens 8k1k --no-evalsgit diff --checkpasses.中文说明
更新 MI355X 上 DeepSeek-V4-Pro FP4 的两条固定序列 8k/1k vLLM 配置:
dsv4-fp4-mi355x-vllm(STP)dsv4-fp4-mi355x-vllm-mtp(MTP)镜像变更:
vllm/vllm-openai-rocm:nightly-09663abde0f50944a8d5ea30120666024b503faavllm/vllm-openai-rocm:nightly-7c5dc571cbd1064ecc8a9b1045637ff647aa22cbsha256:f0bdaf5217a09949842b45c1ea1f12260d3205ec81f143b320dfc2eb3ec95e552026-09-01T05:31:02Z7c5dc571STP 和 MTP 的 8k/1k TP8 并发范围均保持 4-512 不变。
vLLM DSV4 优化核对
与 #2590 使用的 2026-08-17 nightly 相比,新镜像包含以下相关优化:
新合入的 DSV4 kernel 会通过现有的
VLLM_ROCM_USE_AITER=1、VLLM_ROCM_USE_AITER_MOE=1和--moe-backend aiter自动选用。为了与最新 ROCm 配方保持一致,STP 和 MTP 现在还会显式设置:VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=1。当前deepseek-ai/DeepSeek-V4-Pro检查点采用 FP4 routed experts 与 FP8 block-quantized shared-expert 路径;当该路径不满足条件时,最新 vLLM 的兼容性检查会自动关闭此融合。VLLM_ROCM_QUICK_REDUCE_QUANTIZATION=INT4,启用 INT4 量化 quick all-reduce;完整扫描中的准确率评估会覆盖其精度影响。中文验证
git diff --check通过。Note
Medium Risk
Benchmark numbers and accuracy may shift from a new vLLM nightly plus INT4 quick all-reduce; scope is limited to MI355X DSV4 FP4 vLLM STP/MTP configs and launch env, not core serving code.
Overview
Bumps the pinned
vllm/vllm-openai-rocmimage fordsv4-fp4-mi355x-vllmanddsv4-fp4-mi355x-vllm-mtpfromnightly-09663abde0f50944a8d5ea30120666024b503faatonightly-7c5dc571cbd1064ecc8a9b1045637ff647aa22cb(2026-09-01 nightly). TP8 concurrency sweep (4–512) is unchanged; config comments now describe AITER + explicit recipe env vars instead of the older flag list.Aligns the STP and MTP fixed-seq-len launch scripts with the current ROCm recipe by exporting
VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=1andVLLM_ROCM_QUICK_REDUCE_QUANTIZATION=INT4alongside the existing AITER MoE settings. Shared-expert fusion is expected to no-op for this checkpoint when ineligible.Documents the refresh in
perf-changelog.yamlfor both config keys, including the new digest and the upstream DSV4 kernel optimizations picked up in the image.Reviewed by Cursor Bugbot for commit 77dd5ab. Bugbot is set up for automated code reviews on this repo. Configure here.