fix: enforce consistency between CL header metadata and EL payload metadata#190
Open
matthias-wright wants to merge 2 commits into
Open
fix: enforce consistency between CL header metadata and EL payload metadata#190matthias-wright wants to merge 2 commits into
matthias-wright wants to merge 2 commits into
Conversation
|
LGTM. This PR binds the EL payload block number and timestamp to the Summit header during verification so mismatched CL/EL metadata can no longer pass vote-time checks. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR builds on #189 because it addresses a similar edge case, and the code changes are overlapping.
This fixes #185.
Changes:
handle_verifyto enforce that Summit header's block number matches the payload's block number.handle_verifyto enforce that Summit header's timestamp matches the payload's timestamp.