fix: validate fee recipient for proposed block#206
Open
matthias-wright wants to merge 5 commits into
Open
Conversation
|
This appears to verify the fee recipient when treasury mode is nonzero but leaves the zero-treasury/proposer-recipient case unchecked. Should verification require the payload fee recipient to match the expected proposer withdrawal address in that mode, too? |
Collaborator
Author
|
When the treasury address is set to zero, the block proposer may use its own address for the fee recipient (or any other address), so I think this check should cover it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #191 (which builds on #190).
This addresses #200.
Changes:
handle_verify. This check is only performed, if thetreasury_addressis non-zero. If thetreasury_addressis set to the zero address, then block proposers may chose any fee recipient.