ci: hold TypeScript at 6.x in Dependabot updates - #12
Open
vpetersson-bot wants to merge 1 commit into
Open
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
typescript-eslint has no TypeScript 7 support yet (peer range is ">=4.8.4 <6.1.0" as of typescript-eslint 8.70.0). TypeScript 7 removed the `ts.Extension.Cjs` API that @typescript-eslint/typescript-estree reads, so the grouped Dependabot bump to typescript@7.0.2 makes linting crash before it reaches any source file. Ignore typescript >=7.0.0 so the rest of the grouped update can land. Remove the ignore once typescript-eslint supports TypeScript 7. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The grouped Dependabot update in this repo bumps
typescriptto 7.0.2, and thatsingle bump is what fails CI.
typescript-eslinthas no TypeScript 7 support yet —its peer range is
typescript: ">=4.8.4 <6.1.0"as of the current release (8.70.0)and even on the canary channel.
TypeScript 7 (the Go port) dropped the
ts.Extension.CjsAPI that@typescript-eslint/typescript-estreereads, so linting dies before it looks at anysource file:
On npm-based repos the same conflict surfaces earlier, as an
ERESOLVEfailure during install.This is not specific to this repo — the same bump breaks CI in 21 repos across the org.
Fix
Ignore TypeScript
>=7.0.0in the Dependabot config untiltypescript-eslintsupports it.Everything else in the grouped update is fine and should keep flowing.
Verification
Reproduced and verified on
Screenly/clock-app, on the Dependabot branch with everyother update from the group applied and only
typescriptheld at6.0.3:Follow-up
Once
typescript-eslintships TypeScript 7 support, drop theignoreblock (theinline comment says so) and let the bump through.
🤖 Generated with Claude Code