fix(deps): hold typescript below 7 until typescript-eslint supports it - #13
Closed
vpetersson-bot wants to merge 1 commit into
Closed
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
typescript-eslint has no released version that supports TypeScript 7 -- even 8.70.0 declares a peer range of `typescript >=4.8.4 <6.1.0`. Linting under TS 7 throws `Cannot read properties of undefined (reading 'Cjs')` from @typescript-eslint/typescript-estree, which is what keeps the monthly bun group PR red. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
Duplicate of #12, which already proposes the same fix. Closing this one in favour of the earlier PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The monthly
bungroup Dependabot PR in this repo is red, and has been since the group started includingtypescript7. Thechecksjob fails at the Lint step with:Cause
@typescript-eslint/typescript-estreebuilds its default extension set fromts.Extension.Cjs. TypeScript 7 no longer exposesExtensionon the public API surface, sots.Extensionisundefinedand the module throws at import time — before any file is linted.This is not a version-skew problem that a newer
typescript-eslintfixes. Every published version, up to and including the current8.70.0, declares:No released
typescript-eslintsupports TypeScript 7 yet.typescript-eslintreaches this repo transitively through the shared ESLint config in@screenly/edge-apps, so there is nothing to bump here to make TypeScript 7 work.Fix
Have Dependabot hold
typescriptbelow 7 untiltypescript-eslintsupports it. Everything else in the group keeps flowing.Verification
Reproduced and verified locally on
Screenly/clock-appagainst the open group PR. Withtypescriptat^7.0.2,bun run lintfails as above. Pinningtypescriptback to^6.0.3while keeping all eight other updates in the group:After merging
Comment
@dependabot recreateon the open group PR — it will come back without thetypescriptbump and should go green.The same breakage affects every Screenly edge app plus
edge-apps-library; an identical change is going up in each.🤖 Generated with Claude Code