Add All option for disabled audio events - #259
Guffawaffle wants to merge 3 commits into
Conversation
|
I'm not 100% convinced on this one. The idea of an All option brings it in sync with Banners, just don't know that we need all the extra that comes with it. |
|
@netniV I'll take a look and see what I can trim on it. Thanks for the feedback! |
|
@netniV Good call—the first version overbuilt the I've trimmed it back to a wildcard over the existing named-string event filter. The Event-object/hashed-ID detours, raw I also narrowed the documentation so it no longer promises universal audio coverage. Windows runtime testing confirmed that |
|
Review refresh complete at 8162591 (receipt b8595cf2e318a3fd1b491ead436c87c3ae38148f37b85fc0db1004b07f419576). The hostile lane found one low-severity parser defect: the wildcard check passed arbitrary config bytes through C toupper. Commit 8162591 replaces it with an exact, length-aware, allocation-free ASCII comparison and adds compile-time checks for mixed case, embedded NUL, and a high byte. The Windows release mods build and diff-check pass; all three correction lanes now report no confirmed defect. I also refreshed the focused stack range and removed the incorrect suggestion that string-valued alert_* settings accept false. The PR stays draft for exact-head Windows policy evidence plus macOS native hook-fit/runtime validation. |
cfe2227 to
4183124
Compare
|
Hook/feature alignment follow-up for #313 Follow-up to #313: keep hook installation independent of feature enablement, with default-enabled compatibility switches under
Implemented in bc020dc. Existing audioeventhooks now independently controls the single named Fabric route. Inactive/null and processing-failure paths forward native arguments exactly once; All retains start/resume suppression and cleanup precedence. Complete named ABI/reference/Int32 guards and installation result checks are in place without notification/settings scope. Exact Windows build, parser/policy assertions, examples, static Windows fit and three lanes passed. CI is queued; exact audio/Mac qualification and historical maintainer review state remain open. |
Adds case-insensitive All to the existing named audio-event filter: [audio].disabled_events = "All". It suppresses playback-start and resume actions while allowing stop, unload and other cleanup actions through. Exact-name filtering remains available; All takes precedence when combined with names.
Following #313, the existing default-enabled [patches].audioeventhooks controls installation independently of tracing/filter choices. Inactive or null-name callbacks call the original unchanged before converting names; filter-processing failures also forward to native behavior. The one existing Fabric detour resolves the complete unique named-string instance signature, reference arguments and Int32 action enum, and checks installation success. Direct event objects and hashed-ID routes are unaffected. This PR is standalone against dev; no notification or settings stack is imported.
Validation: Windows release build, existing compile-time parser/filter policy assertions and all 11 example TOMLs pass. Three independent reviews cover the exact candidate. Static Windows270 evidence covers the selected Fabric overwrite window; exact-artifact audio runtime and supported Mac extent/execution remain unqualified. CI starts on publication without waiting for results.