Skip to content

[TESTING ONLY] Combined improvements for macOS validation - #257

Closed
Guffawaffle wants to merge 99 commits into
STFC-Mod:devfrom
Guffawaffle:testing/all-improvements-macos
Closed

Guffawaffle wants to merge 99 commits into
STFC-Mod:devfrom
Guffawaffle:testing/all-improvements-macos

Conversation

@Guffawaffle

@Guffawaffle Guffawaffle commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Testing only — do not merge. This draft PR exists to produce CI artifacts for combined Windows/macOS testing while the individual feature PRs remain the review and merge units.

Purpose

Provide one installable build containing the current improvement stack for integrated Windows/macOS testing.

Included work

This branch also includes the current dev version bump to 1.1.7.1.

Test configuration

[audio]
disabled_events = "All"
alert_fleet_arrived_in_system = "arrival"

[ui]
allow_officer_preset_reordering = true

[shortcuts]
toggle_shortcut_hints = "F7"

All suppresses Scopely/Fabric actions that start or resume playback while forwarding stop, stop-all, unload, and other cleanup/control actions. Mod-generated alert_* cues are independent; set unwanted mod alerts to none or false.

Officer-preset reordering is local-only: Shift-click a preset's edit-name pencil to move it up and Ctrl-click to move it down. The default profile stores order in community_patch_state.json; custom -ccm profiles use sibling <config-name>.state.json files.

Suggested smoke test

  • Client launches and the mod installs its expected hooks without layout or duplicate-target errors.
  • Existing navigation shortcuts still behave correctly.
  • F7 opens and closes Scopely's shortcut-hint overlay with the current mod bindings; native-only suppressed actions show -.
  • Modifier chords use AutoHotkey notation (^ Ctrl, ! Alt, + Shift, # Win/Command); literal modifier-like keys remain unambiguous.
  • Disable hotkeys while the overlay is open, re-enable them, and reopen it; labels refresh without stale values or crashes.
  • Fleet Watch reaches its stable seed state (allow at least five seconds after startup/system hydration before judging transitions).
  • With the configuration above, normal Scopely audio is silent but the fleet-arrival ding remains audible.
  • Travel, combat, UI navigation, and queued audio transitions do not crash or leave audio state stuck.
  • Fleet transition notifications work on macOS.
  • Fleet alerts play from [audio] configuration alone, with no matching [ui].notify_fleet_events entry; false, none, and invalid values remain silent.
  • Bulk-claim flyout opens on eligible screen entry and reopens after bulk claim completion when it was not manually closed.
  • Fleet-label zoom control behaves at always-on, always-off, and fractional thresholds.
  • A normal officer-preset pencil click opens rename; Shift-click moves up; Ctrl-click moves down; releasing modifiers restores rename behavior.
  • Officer-preset reordering preserves scroll position and survives screen close/reopen plus a full client restart.
  • After moving a preset, rename or overwrite that moved row and verify the intended preset changes; disabling reordering restores Scopely's native server order.
  • Custom config profiles use independent state files; simultaneous clients do not corrupt saved JSON.

Please include OS version, architecture, config values exercised, and relevant community_patch.log lines with any report.

Validation

  • Exact signed head: c3774fa561e45bb27633c32f41caab287f984105
  • Local Windows releasedbg aggregate DLL build: passed.
  • Exact combined head cold-started on Windows with 29/29 patch traversal, 26 installed patches, 3 expected skips, and no runtime warnings/errors.
  • Exact Add local officer preset reordering #260 correction head cold-started on Windows and loaded 20 persisted positions without warnings/errors.
  • All 11 example TOMLs: passed validation.
  • git diff --check: passed.
  • Local worktree: clean.
  • GitHub CI is running for the refreshed exact head: Windows, macOS arm64, macOS x86_64, universal macOS packaging, and example validation.
  • Exact-head build and artifacts

Disposition

This PR should remain draft and must not be merged. Findings should be applied to the owning individual PR(s), then this integration branch can be refreshed or removed.

lightbull-stfc and others added 30 commits August 10, 2026 18:04
- Update xmake version to latest in CI jobs
- Implement matrix strategy for macOS builds to support arm64 and x86_64 architectures
- Add steps for packaging intermediate builds and uploading artifacts
- Improve diagnostics and validation steps for build artifacts
…ovenance-217

# Conflicts:
#	.github/workflows/ci.yaml
@Guffawaffle

Copy link
Copy Markdown
Contributor Author

Retiring this testing-only aggregate rather than rebasing it. Its constituent features have since been split, corrected, and reviewed independently, so keeping this 64-file integration snapshot current would create misleading review and validation evidence. A fresh temporary integration branch can be assembled from current heads when cross-feature macOS testing is needed.

@Guffawaffle Guffawaffle closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants