Repository navigation
Add Scopely-native navigation shortcut actions - #254
Merged
netniV merged 8 commits intoSep 5, 2026
Merged
Conversation
This was referenced Aug 30, 2026
Contributor
Author
|
Review refresh complete at 156de8f, receipt 1309ea1e3db34aff444e943f63f03b931fb1231b22d8e426750a01182cef5b02. All three lanes found no confirmed source defect; the Windows release mods build and all CI checks pass. Native-code inspection confirms both callbacks retain CanUseShortcuts and ignore the zero callback context. Static integration with #266 is conflict-free. The PR description now reflects the observer/consumer split, clarifies that the earlier F5 test used a custom binding, and records the remaining macOS and camera-mode runtime coverage. |
netniV
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add native_shortcut_galaxy and native_shortcut_events bindings that invoke Scopely's own navigation callbacks. The existing show_galaxy and show_events actions continue to navigate directly to their configured sections.
Defaults are CTRL-G and CTRL-E. These bindings operate in mod-hotkey mode; Scopely-hotkey mode uses Scopely's bindings. F5 remains the default for zoom_preset5. The legacy show_galaxy_native name remains an alias.
Mod keyboard camera actions now honor hotkeys_enabled and use_scopely_hotkeys. Automatic default zoom and native mouse behavior remain active.
Validation and review
Remaining evidence
Dependencies
This PR is independent of #253. The observer-only #255 no longer depends on either PR. #268 consumes #255 and excludes native shortcut work.