fix(lang): per-source copy attribution in MemoryTracker; volatile ActiveMemoryTracker (#931) - #938
Merged
Conversation
…iveMemoryTracker MemoryTracker.recordCopy(sourceName, bytes) discarded sourceName — it only bumped copyCount/copyBytes, while every instrumented call site passes a meaningful label (CopyMaterializationStrategy, DenseTensorDataFactory.createFloatTensorData, ...). The API promised per-source attribution and threw it away. Aggregate reports now carry copiesBySource: Map<String, CopySourceStat> (count + bytes per code path), included in the report's text form sorted by volume, and reset by clear(). ActiveMemoryTracker.current becomes @volatile so installing/clearing a tracker is visible across threads, and its doc now states the honest contract: the tracker itself is not synchronized, concurrent sessions should install their own around their critical section. Replacing the process-wide hook with a per-execution-context tracker is part of the SKEEP-003 storage-model discussion (#932) and intentionally out of scope here. Tests: per-source aggregation across repeated and distinct sources, clear() resetting attribution, and the text report containing the breakdown. Closes #931
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
aharakal
previously approved these changes
Aug 10, 2026
Resolve the [Unreleased] CHANGELOG conflict with the merged #930 entry: keep all bullets.
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
aharakal
approved these changes
Aug 10, 2026
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full analysis in #931.
recordCopystops discarding its label: aggregate reports gaincopiesBySource: Map<String, CopySourceStat>(count + bytes per code path), rendered in the text report sorted by volume, reset byclear(). Profiling sessions can finally see which path produced the copy traffic — the attribution the API always appeared to offer.ActiveMemoryTracker.currentis@Volatilewith an honest thread-safety contract in the docs (tracker itself unsynchronized; concurrent sessions install their own). Replacing the process-wide hook with a per-execution-context tracker is deliberately left to the SKEEP-003 storage-model discussion (TensorData and TensorStorage are parallel layers — unify the storage model (ownership, views, dtype/encoding, placement): SKEEP-003 discussion anchor #932) — noted in the docs so the limitation is discoverable.AggregateMemoryReportgains the new field with a default value — source-compatible for any external constructors.Verified:
:skainet-lang:skainet-lang-core:jvmTestgreen (full module).Note: CHANGELOG entry included — trivial
[Unreleased]conflicts expected with the sibling #927–#930 PRs.Closes #931