docs(skeep): SKEEP-003 amendment — deprecate-don't-delete migration rule + implementation slices (#782, #921) - #963
Merged
Conversation
…mentation slices (#782, #921), 0.39.0 status Amends the SKEEP-003 draft with what the first concrete work on it taught: - Compatibility and Migration now states the binding rule explicitly — the 0.39.0 public API is preserved, deprecate-don't-delete — with the GgufParametersLoader deprecation as the house pattern and the #782 slice as the worked example (additive constructor parameter defaulting to historical behavior; implementation swap behind an unchanged type). - New Implementation Slices section maps #782 (streaming dequant — the staging stage of improvement 4, landed) and #921/SKEEP-002 (Android off-heap/mmap — the mobile destination-placement stage) as slices of this proposal, and records #927-#931 as landed in 0.39.0. - Motivation gains the 'copy semantics are ambient' cost: the factory's defensive copyOf vs the wrapFloatArray borrow path, as measured in #782. Refs #932 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
This was referenced Aug 11, 2026
Merged
aharakal
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-doc amendment for the SKEEP-003 draft (
docs/modules/skeep/pages/003-unified-tensor-storage.adoc), anchoring #932. Docs-only.The draft landed in #933 with the analysis and the two candidate end-states. This amendment adds what executing the first slice of it taught:
What changes
@Deprecated+ReplaceWith(the existingGgufParametersLoader→StreamingGgufParametersLoaderdeprecation is the house pattern); changes to existing classes are additive-with-historical-defaults or implementation swaps behind an unchanged type. Zero-consumer dead code is the one exemption, with evidence required per PR.copyOffor every tensor because ownership transfer isn't expressible in the creation API. Fixed concretely in the sibling PR (fix/782-dequant-overalloc).copyOfvs thewrapFloatArrayborrow path; 41x boxed materialization in the legacy reader).The end-state question (storage-first vs data-first) remains deliberately open for maintainer discussion on #932 — this amendment only hardens the parts that are invariant under both.
Refs #932
🤖 Generated with Claude Code