security: npm ci for the docs image; no unpinned npm install in the docs preview job - #1291
Merged
Merged
Conversation
…review-server install Scorecard Pinned-Dependencies flagged two npm installs. The docs image now declares its five inputs in package.json and installs them with npm ci from a committed package-lock.json, which pins every transitive package by integrity hash (git dependencies by commit over https). The docs preview job serves the artifact with python3 -m http.server instead of a freshly downloaded, unpinned serve package, which also removes its setup-node step.
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
This was referenced Sep 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two OpenSSF Scorecard Pinned-Dependencies code-scanning alerts (#80
docs/.docker/Dockerfile:55, #54.github/workflows/documentation.yml:105). The base image and all actions were already pinned by hash; what Scorecard flags is the twonpm installcommands.docs/.docker/package.json;package-lock.jsonpins all 443 packages by integrity hash and theRUNbecomesnpm ci. Git dependencies are recorded asgit+https://so the build never depends on npm's ssh→https fallback. The lockfile was generated inside the same pinnednode:20-alpinedigest.npm install -g serve→python3 -m http.server 3000; thesetup-nodestep that existed only for it is gone.Verified locally: two
docker build --no-cacheruns green;antora3.1.15 andmmdc11.16.0 present, extensions resolvable; the real site builds with the image (antora-playbook.yml, exit 0, 0 errors).