security: override js-yaml to 4.3.2 in the docs image - #1292
Merged
Merged
Conversation
Committing the docs image lockfile made its npm graph visible to Dependabot: Antora and cosmiconfig resolve js-yaml 4.1.1 (GHSA-2883-xcg3-v3hh and three earlier quadratic-CPU advisories). An npm override pins 4.3.2; only that lockfile entry changes. Image rebuilt from scratch and the docs site renders unchanged.
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1291. Committing
docs/.docker/package-lock.jsonmade the docs image's npm graph visible to Dependabot for the first time, which surfaced js-yaml 4.1.1 (pulled by@antora/content-aggregator,@antora/playbook-builder,@antora/ui-loader,cosmiconfig) — alerts #130, #131, #132, #135. Same package versions were in the image before; they were just not tracked.Fix: npm
overrides→js-yaml: 4.3.2indocs/.docker/package.json; lockfile regenerated inside the pinnednode:20-alpinedigest (npm install --package-lock-only), only the js-yaml entry changes.Verified:
docker build --no-cachegreen; the real site builds with the image (Antora parses its YAML playbook through js-yaml): exit 0, 0 errors, 72 pages, 10 with rendered diagrams — same as before.Not addressed here:
extract-zip2.0.1 (#133, #134) has no patched release; it is only reachable through@puppeteer/browsers' browser download, which the image disables (PUPPETEER_SKIP_DOWNLOAD=true, Alpine Chromium is used instead).