chore(bcv): regenerate the lang-core API dump missed by #1171 - #1174
Merged
Merged
Conversation
#1171 merged the BitNet-planes public surface (TernaryCodec decode/encode/planesRowScale additions, BitNetPlanesTensorData) without regenerating skainet-lang-core.api, so apiCheck fails on develop — which CI does not run on PRs, but every local pr-gate and the golden-parity job do (it is what turned #1172 red). Purely additive dump regeneration, no code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rands The JVM vector paths guarded on 'data as? FloatArrayTensorData', so a slab-backed operand — what a ForwardScope produces since #1145/#1146 — silently fell back to the common scalar loops: correct, but the JVM lost SIMD exactly where the scope machinery is in use. The vector entry points now read dense-FP32 windows (array + base offset) matching both plain array data and StorageFloatTensorData: vectorFloatBinary in all four broadcast shapes, vectorFloatUnary (relu &c.), silu, the reduce-all sum (same left-to-right accumulation order, offset base), and the FP32 matmul FloatArray path — whose kernel SPI already took offsets; only BLAS keeps its offset-0 guard, since the JNI shim takes whole arrays. JvmVectorKernels.binaryFloat/unaryFloat gain default-0 offset parameters. SlabOperandVectorPathTest drives every vector-eligible shape with both operands sliced from a slab at nonzero offsets (length 67 — no species multiple) and requires bit-identical results vs Ambient: the tightest guard against off-by-offset reads, which produce plausible garbage rather than crashes. Closes #1173. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…offset-operands JVM Panama vector kernels accept slab-backed (offset) FP32 operands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
develop currently fails
apiCheck: #1171 merged the BitNet-planes public surface without regeneratingskainet-lang-core.api. CI doesn't run apiCheck on PRs, but every localpr-gate.shand the golden-parity job do — this is also what turned #1172's golden-parity leg red (that branch additionally needs its own dump for its lm_head additions). Purely additive dump regeneration, no code changes.🤖 Generated with Claude Code