ci: give apiCheck its own named PR leg - #1176
Merged
Merged
Conversation
apiCheck already ran in PR CI — inside the golden-parity matrix leg (#1005) — and it caught both recent incidents; but a stale api dump surfaced as a red 'test (golden-parity)' that nobody associates with binary compatibility, and #1171 merged through exactly that red, breaking apiCheck on develop until #1174. The check moves to its own matrix entry: a stale dump now reads as 'test (api-compatibility) ✘' with the fix ('run apiDump, commit the dumps') one association away. golden-parity goes back to being purely the packed-encoding gate. The build-job aggregator needs the whole matrix, so no other wiring changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apiCheck was already in PR CI — buried inside the
golden-paritymatrix leg (#1005), which is why a stale API dump showed up as a red parity leg nobody associates with binary compatibility, and #1171 merged straight through it (repaired by #1174).This splits it into its own matrix entry, so a stale dump reads as
test (api-compatibility)✘ with the fix one association away, andgolden-paritygoes back to being purely the packed-encoding gate. Thebuild-jobaggregator depends on the whole matrix, so no other wiring changes.The remaining hole is enforcement, and it is a settings decision, not a workflow one: nothing blocks merging while checks are red. If you want that closed, branch protection on
developrequiringbuild-job(the aggregator) does it — one admin toggle; happy to apply it on your word.🤖 Generated with Claude Code