Repository navigation
Charts: measurement coverage and catch-model sample selection - #152
Conversation
- Coverage copy: dashed cells (not grey) mark no eligible records, and the colours flip in dark mode, so cells now carry their share as a label (>99% and <1% instead of rounding to 100% or 0%). Plainer wording. - Set panel adds start time and crew size, both fields the model needs. - Coverage moves below the import summary on /data-quality. - Selection flow: one chart instead of three near-identical ones; short labels, a rule column, nursery counts, thresholds from exported constants, species names instead of codes, and which variables the incomplete sets lack (overlapping). It sits in the model section and also shows when the model can't be fitted (the synthetic fixture). - Tests reconcile the flow with the fitted sample sizes. - DataTable: scroll regions get a name per table and keep a tab stop only when they overflow (every table rendered focusable on the server). - Heatmap: labels on the strong end of the sequential scale were white in dark mode, where those cells are pale; new --seq-strong-ink token. - AGENTS.md notes moved into the catch model list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed against the real data (aggregates only) and current
On the real data the flow reconciles with
I pushed fixes in 8a5cdc0. 1. The copy described colours that aren't on the chart. "Grey means no eligible records" no longer holds: since #136, empty cells are dashed outlines. "Pale blue means 0%, dark blue 100%" is reversed in dark mode, where the scale runs from dark to pale. Each cell now shows its share as a label. Shares just short of 100% or just above 0% read ">99%" and "<1%", so they don't round to a complete or empty column. The copy explains dashed cells without naming colours. 2. Heatmap labels in dark mode (shared, existing bug). Labels on the strong end of the scale were always white. In dark mode those cells are pale ( 3. Three nearly identical selection charts. On the real data all three matched in the first three bars, and the all-shark chart matched the blacktip one throughout. It's now one chart: the three shared filters, then the two species models, labelled as starting again from the all-shark sample. Also:
4. Placement. Both sections opened their pages, ahead of the pages' own content.
5. A chart for when there's no model. The fixture's 40 sets can't fit the model, so 6. Scrollable tables (#150).
7. Smaller fixes
Merging with #151. Both PRs edit /drivers and the catch model. A trial merge is clean in either order and passes Checks after the fixes:
|
Adds measurement-availability heatmaps to /data-quality, with recorded/eligible counts and CSV exports for field captures and gillnet sets. Zero values remain recorded; empty denominators remain missing. Lavage-result coverage uses the sampled-or-result-present subset and separately reports unknown and explicitly unsampled records.
Adds selection-flow charts to /drivers and extracts the model's existing filters into selectCatchModel(), so chart counts and fitted samples use the same rules. Selection eligibility is explicitly distinguished from a successful fit.
Also makes shared horizontally scrolling data tables keyboard reachable; mobile axe testing exposed the existing issue while validating the new coverage tables.
Closes #123. Closes #150.
Validation: lint; svelte-check (0 errors/warnings); 97 unit tests; read-only real-data import; production build; full Playwright suite, including new mobile/light/dark accessibility coverage. Browser checks use an ignored local configuration with a separate port. No source spreadsheets or local test configuration committed.