Skip to content

Fixture: enough synthetic sets for the catch model to fit in CI #153

Closed

Description

@Luen

What

scripts/make-fixture.mjs writes one season (2021-22) of 40 gillnet sets across five nurseries. The catch model (analytics/catchModel.ts) needs at least 200 complete sets (MIN_MODEL_SETS), nurseries with at least 30 of them (MIN_SITE_SETS), two nurseries and two seasons. So on the fixture catchModel() returns null, and the whole model section on /drivers never renders in unit tests, Playwright or the axe checks.

Why

Everything below is only checked by hand on the private data:

A layout or accessibility regression in any of them would reach the site unnoticed.

Acceptance

  • The fixture has at least two seasons and enough timed sets (with every model variable) for catchModel() to fit the all-shark and blacktip models; ideally the lemon model too, through one nursery with lemons.
  • Values stay synthetic (seeded random, no real records), as now.
  • e2e/model-diagnostics.spec.ts stops taking its "no model" branch; the pages test and axe cover the model section in light and dark.
  • Unit and e2e run time stays reasonable (check the CI job time before and after).

Part of #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestinfrastructureCI, workflows and deployment

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions