Skip to content

Fix Workers CI typecheck failure in merchants registration validation #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix Workers CI typecheck failure in merchants registration validation #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83f9bb3
Initial plan
Copilot Sep 8, 2026
2342e84
Fix merchants route type narrowing for CI typecheck
Copilot Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/api-edge/src/routes/merchants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,15 +281,19 @@ router.post('/register', async (c) => {
if (!name || typeof name !== 'string' || name.length < 3 || name.length > 255) {
return c.json({ error: 'Validation error', details: ['"name" must be 3–255 characters'] }, 400);
}
if (!email || !isValidEmail(email)) {
if (typeof email !== 'string' || !isValidEmail(email)) {
return c.json({ error: 'Validation error', details: ['"email" must be a valid email'] }, 400);
}
// walletAddress is optional — only validate format when provided
if (walletAddress !== undefined && walletAddress !== null &&
(typeof walletAddress !== 'string' || walletAddress.length < 32 || walletAddress.length > 44)) {
return c.json({ error: 'Validation error', details: ['"walletAddress" must be a valid Solana address (32–44 characters)'] }, 400);
}
if (webhookUrl !== undefined && webhookUrl !== null && !isValidUri(webhookUrl as string)) {
if (
webhookUrl !== undefined &&
webhookUrl !== null &&
(typeof webhookUrl !== 'string' || !isValidUri(webhookUrl))
) {
return c.json({ error: 'Validation error', details: ['"webhookUrl" must be a valid URI'] }, 400);
}

Expand Down