Draft
Fix Workers CI typecheck failure in merchants registration validation#253
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-authored-by: Rumblingb <190477445+Rumblingb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Workers
Fix Workers CI typecheck failure in merchants registration validation
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Workers GitHub Actions job was failing at
tsc --noEmitdue to insufficient type narrowing inPOST /api/merchants/register. Union-typed request fields (string | number) were used as strings before runtime type guards guaranteed that shape.Root cause in
merchants.tsemailwas passed toisValidEmail()while still typed asstring | number.webhookUrlcould be non-string at validation time, leaving downstream string operations unsafe.Targeted fix
typeof email === 'string'before email validation/normalization.typeof webhookUrl === 'string'before URI validation.Resulting behavior