ItemUpgrades.lua Cancelling the search function#354
Open
StrahinjaT97 wants to merge 16 commits into
Open
Conversation
…utton. -Appended properties to ahSession to accomodate new functionality -Added tracking of scan function calls and an optional max scan function calls set to defualt 10 -Switched around checks when creating gui. No need to create an embeeded gui if no results/is canceled.
SabreValkyrn
requested changes
Apr 8, 2026
SabreValkyrn
left a comment
SabreValkyrn
left a comment
Collaborator
There was a problem hiding this comment.
This workflow doesn't work as is, but a few comments on the code to start with.
On TBC: When I Search, it'll RestedXP Guides - Auctioneer - Armor (860%), button will be changed to Cancel, then the AH frame says Search canceled and no results are populated.
Co-authored-by: SabreValkyrn <61754281+SabreValkyrn@users.noreply.github.com>
Collaborator
This is still the case, except it's |
…97/RXPGuides into feature/item-upgrades sync branch with origin
SabreValkyrn
approved these changes
Apr 14, 2026
Collaborator
|
Fixes #352 |
Deleted some comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to cancel the search. If there are cached results, the canceled search will display them.
Fixed the percentage going over 100% in the frame title.
Added auto-canceling on deep scans.