Update ItemUpgrades.lua

[gnummers]

Allows max level characters to scan the Auction house for item upgrades
Added improvements to mitigate any crashing or looping during AH scanning
Added fallback stat weights for all classes/specs in TBC so they would get accurate upgrade results

[SabreValkyrn]

Allows max level characters to scan the Auction house for item upgrades

This was explicitly not allowed, these values are for leveling not raiding. So explicitly and intentionally disabled at max level to avoid misconstrued gear choices.

Added improvements to mitigate any crashing or looping during AH scanning

Awesome! I've been meaning to do this, will leverage a lot of your work here.

Added fallback stat weights for all classes/specs in TBC so they would get accurate upgrade results

Stat weights come from an internal GSheet then processed with https://github.com/RestedXP/RXPGuides/blob/main/Scripts/stat_weights.py so these values should not belong in this file. What goal are you trying to solve with those non-zero defaults?

[gnummers]

Allows max level characters to scan the Auction house for item upgrades

This was explicitly not allowed, these values are for leveling not raiding. So explicitly and intentionally disabled at max level to avoid misconstrued gear choices.

This allowed us (myself and my friends that play) to scan for gear, at max level, and find upgrades from the auction house. If you use another addon, like Pawn, you can still analyze the results to see if they're truly valid upgrades for raiding, or whatever the use case may be.

Added improvements to mitigate any crashing or looping during AH scanning

Awesome! I've been meaning to do this, will leverage a lot of your work here.

Thank you! Nice!

Added fallback stat weights for all classes/specs in TBC so they would get accurate upgrade results

Stat weights come from an internal GSheet then processed with https://github.com/RestedXP/RXPGuides/blob/main/Scripts/stat_weights.py so these values should not belong in this file. What goal are you trying to solve with those non-zero defaults?

For example, without non-zero defaults, when scanning the auction house at max level as a mage, it would return gear that would have weird stats, like agility and strength. Having non-zero defaults allowed the scan results to be more accurate to what each class would actually be looking for.

[gnummers]

Tested again after the latest AH fixes and this is now working correctly on our side.

The empty Auction House results pane ended up being a combination of post-scan issues in ItemUpgrades.lua: async item-info timing, incomplete item weights during analysis, and the embedded results view not always refreshing/populating cleanly. The follow-up fixes on this branch now:

• prefer the full AH itemLink during scan analysis
• re-run analysis/results when item info arrives late
• guard the scan against incomplete item weights instead of erroring during finalization
• force the embedded AH results view to refresh/populate correctly
• emit clearer debug/no-results messages during troubleshooting

After testing, the scan is now completing and the item/weapon upgrade rows are showing in the Auction House window as expected.

Also, thank you to our Dutch friend for all the help testing this.

[SabreValkyrn]

#354 should address the abort/cancellation and runaway retry issues.

Enabling faked max level scanning is not something we want to support at this time.

There are some other interesting changes in here that I'll review further and probably pull out separately.