Skip to content

[Snyk] Fix for 2 vulnerabilities #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RayG-XD wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −21
Open

[Snyk] Fix for 2 vulnerabilities #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"dependencies": {
"@angular/animations": "^14.0.0",
"@angular/common": "^14.0.0",
"@angular/compiler": "^14.0.0",
"@angular/core": "^14.0.0",
"@angular/compiler": "^19.2.18",

@cubic-dev-ai cubic-dev-ai Bot Jan 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0: Critical version mismatch: This PR only updates @angular/compiler and @angular/core to v19, while all other Angular packages remain at v14. Angular packages must be at the same major version. This will cause peer dependency errors during npm install and runtime failures. All @angular/* packages need to be upgraded together to v19, along with compatible versions of zone.js, rxjs, and typescript.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 18:

<comment>**Critical version mismatch**: This PR only updates `@angular/compiler` and `@angular/core` to v19, while all other Angular packages remain at v14. Angular packages must be at the same major version. This will cause peer dependency errors during npm install and runtime failures. All `@angular/*` packages need to be upgraded together to v19, along with compatible versions of `zone.js`, `rxjs`, and `typescript`.</comment>

<file context>
@@ -15,8 +15,8 @@
     "@angular/common": "^14.0.0",
-    "@angular/compiler": "^14.0.0",
-    "@angular/core": "^14.0.0",
+    "@angular/compiler": "^19.2.18",
+    "@angular/core": "^19.2.18",
     "@angular/fire": "^7.1.0",
</file context>
Fix with Cubic

"@angular/core": "^19.2.18",
"@angular/fire": "^7.1.0",
"@angular/forms": "^14.0.0",
"@angular/platform-browser": "^14.0.0",
Expand Down