[Snyk] Fix for 2 vulnerabilities - #13
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ANGULARCOMPILER-14908872 - https://snyk.io/vuln/SNYK-JS-ANGULARCORE-14908871
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Warning
|
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="package.json">
<violation number="1" location="package.json:18">
P0: **Critical version mismatch**: This PR only updates `@angular/compiler` and `@angular/core` to v19, while all other Angular packages remain at v14. Angular packages must be at the same major version. This will cause peer dependency errors during npm install and runtime failures. All `@angular/*` packages need to be upgraded together to v19, along with compatible versions of `zone.js`, `rxjs`, and `typescript`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "@angular/common": "^14.0.0", | ||
| "@angular/compiler": "^14.0.0", | ||
| "@angular/core": "^14.0.0", | ||
| "@angular/compiler": "^19.2.18", |
There was a problem hiding this comment.
P0: Critical version mismatch: This PR only updates @angular/compiler and @angular/core to v19, while all other Angular packages remain at v14. Angular packages must be at the same major version. This will cause peer dependency errors during npm install and runtime failures. All @angular/* packages need to be upgraded together to v19, along with compatible versions of zone.js, rxjs, and typescript.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 18:
<comment>**Critical version mismatch**: This PR only updates `@angular/compiler` and `@angular/core` to v19, while all other Angular packages remain at v14. Angular packages must be at the same major version. This will cause peer dependency errors during npm install and runtime failures. All `@angular/*` packages need to be upgraded together to v19, along with compatible versions of `zone.js`, `rxjs`, and `typescript`.</comment>
<file context>
@@ -15,8 +15,8 @@
"@angular/common": "^14.0.0",
- "@angular/compiler": "^14.0.0",
- "@angular/core": "^14.0.0",
+ "@angular/compiler": "^19.2.18",
+ "@angular/core": "^19.2.18",
"@angular/fire": "^7.1.0",
</file context>
Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-ANGULARCOMPILER-14908872
SNYK-JS-ANGULARCORE-14908871
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)
Summary by cubic
Fixes 2 high-severity XSS vulnerabilities by upgrading @angular/core and @angular/compiler to 19.2.18. This may require updating Node and aligning Angular peer dependencies.
Dependencies
Migration
Written for commit 039bafc. Summary will update on new commits.