Skip to content

fix(params): don't use paramsSave automatically #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PonomarevDA merged 5 commits into from
Aug 20, 2026
Merged

fix(params): don't use paramsSave automatically #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be8eb53
fix: don't use paramsSave
Ilyhadev Jul 28, 2026
fbece92
fix: don't overwrite health
Ilyhadev Jul 28, 2026
50064a5
last libprarams
Ilyhadev Jul 28, 2026
920927d
chore: libparam update
Ilyhadev Jul 29, 2026
6c5c989
chore: update libs
Ilyhadev Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libs/Dronecan
Open in desktop
Submodule Dronecan updated from 6be0f6 to c4db8c
2 changes: 1 addition & 1 deletion Libs/libparams
Open in desktop
Submodule libparams updated 3 files
+6 −0 include/libparams/storage.h
+37 −3 src/storage.c
+136 −5 tests/unit_tests/test_storage.cpp
8 changes: 6 additions & 2 deletions Src/modules/application/application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,14 @@ static int8_t init_board_periphery() {
if (paramsLoad() != 0) {
return -1;
}
if (!paramsIsCrcValid()) {
(void)paramsSave();
bool is_erased = false;
(void)paramsIsErased(&is_erased);

if (!paramsIsCrcValid() && is_erased) {
(void)paramsResetToDefault();
}


#if defined(CAN1_TERMINATOR_Pin) && defined(CAN2_TERMINATOR_Pin)
auto teminator_param = paramsGetIntegerValue(IntParamsIndexes::PARAM_SYSTEM_CAN_TEMINATOR);

Expand Down
4 changes: 3 additions & 1 deletion Src/modules/system/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ REGISTER_MODULE(SystemModule)

void SystemModule::init() {
need_notification = paramsGetIntegerValue(IntParamsIndexes::PARAM_LOG_LEVEL) <= 1;
set_health(Status::OK);
set_health(paramsIsCrcValid()
? Status::OK
: Status::MINOR_FAILURE);
set_mode(Mode::STANDBY);
}

Expand Down
Loading