fix(params): don't use paramsSave automatically - #140
Merged
Conversation
Collaborator
Author
|
Still in draft because need tests on new libparams |
|
Ilyhadev
marked this pull request as ready for review
August 20, 2026 09:12
Collaborator
Author
|
Retested on f103, g0b1, h7. Change of name and id was tested. New behaviour: on "fresh" nodes - since app doesn't perform save on it's own crc of libparams doesn't align, which causes minor failure to rise. This is solved by saving params by pressing "save all" in dronecan. |
PonomarevDA
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes paramsSave from param startup in application