Repository navigation
test(a11y): menu titles and items are one semantics node (#1815) - #1831
Merged
Merged
Conversation
github-actions
Bot
added
bug
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1815 reported every menu title twice in a semantics snapshot. The menus are stock Material
MenuBar/MenuItemButton, which merge their semantics, so the duplication may come from the snapshot tool, not from the app. This adds the test the issue asks for: it counts the nodes of a menu bar and of an open context menu. If it passes, the issue is not an app bug and gets closed; if it fails, the failure shows which nodes are doubled and the fix follows in this PR.Refs #1815