Repository navigation
fix(ui): audit of the silent catch blocks in lib/features and lib/shared (#1762) - #1800
Merged
Merged
Conversation
…, three tell the user (#1762)
github-actions
Bot
added
bug
test(guards): no empty catch blocks in lib/features and lib/shared (#1763)
This was referenced Oct 25, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1762.
27 empty or comment-only
catchblocks classified:Told to the user (
reportError, which also logs): the demo playground that failed to open (the button did nothing), the file chooser of the SQLite form.Logged (
logIgnored, harmless best-effort code): MCP activity list, SQLite view probe and file size, extension row-count fallback, Redis CLI history load/save and the sentinel clean-up, Mongo database sizes, view mode and count, query history, ERD layout save, PostgreSQL materialized views, extension driverOptions, export clean-up.DataExportServicealso logs why an export failed (it only returned the outcome before).Left as they are on purpose, because the failure is the control flow: the parse-and-fall-back attempts in
mql_parser,mongo_field_codecanddata_grid_value_panel(pretty-print/minify of a value that may not be JSON or XML).The issue's example about
listDatabasesin the Mongo databases view is the sizes lookup now; the main listing already reports its failure (#1798). Not run locally, CI will.