Repository navigation
test(guards): no empty catch blocks in lib/features and lib/shared (#1763) - #1801
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1763. Stacked on #1800 (base is its branch; GitHub retargets it to dev when #1800 is merged).
A guard test, in the style of the other ones in
test/guards: an empty or comment-onlycatchblock inlib/featuresorlib/sharedfails the test; it must calllogIgnored, a reporting helper, rethrow or handle the error. After the audit in #1800 eight blocks remain on purpose (parse-and-fall-back inmql_parser,mongo_field_codec,data_grid_value_panel); they are listed with their exact count, so the number has to go down when one is removed.The
unawaited(...)calls mentioned in the issue are not covered here. Not run locally, CI will.