Skip to content

Rename lln_clt to lln_clt_intro so lecture names are unique across the published sites - #856

Merged
mmcky merged 1 commit into
mainfrom
rename-lln_clt
Oct 9, 2026
Merged

mmcky merged 1 commit into
mainfrom
rename-lln_clt

Conversation

@mmcky

@mmcky mmcky commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Part of QuantEcon/project-monorepo#76. QuantEcon/lecture-python.myst publishes a different lecture as lln_clt, and the lectures monorepo needs every lecture name to be unique across the published sites. QuantEcon/project-monorepo#75 ruled that the intro side takes an _intro suffix.

What this changes

  • lectures/lln_clt.md is renamed to lectures/lln_clt_intro.md, and its _toc.yml entry follows it.
  • lectures/_config.yml gains lln_clt.md: lln_clt_intro.md under rediraffe_redirects, so the old address redirects to the new one.
  • Five links to it are updated, in heavy_tails, markov_chains_II, monte_carlo and observed_distributions (2). No other series links to intro's lln_clt by name; I checked all six.
  • Checked on the branch:
    • the redirect's old file is gone and its new file exists;
    • every _toc.yml entry has a file;
    • no {doc} link points at a missing file.

The translation hold is cleared: action-translation v0.29.4 (2026-10-09) carries QuantEcon/action-translation#291, and v0, which sync-translations-zh-cn.yml runs, now points at it. This PR stays a draft until the one before it has merged and this one is rebased.

🤖 Generated with Claude Code

@netlify

netlify Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 53447e7
🔍 Latest deploy log https://app.netlify.com/projects/taupe-gaufre-c4e660/deploys/6ac879a41f1d580008552171
😎 Deploy Preview https://deploy-preview-856--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mmcky

mmcky commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

The red checks are expected.

What fails: the HTML build stops on one warning and nothing else: (broken) lln_clt.html redirects to lln_clt_intro.html but _build/html/lln_clt.html already exists!.

Why: CI restores the build cache that cache.yml built from main. That cache still holds the old page, and rediraffe overwrites only the redirect pages it wrote itself. The other builds pass.

How it lands: each of the three intro PRs stays red until it is merged. After each merge:

  1. Run cache.yml on main.
  2. Push no publish* tag until that run is green.
  3. Then rebase the next PR.

This is on top of the hold for QuantEcon/action-translation#291.

…e sites

QuantEcon/lecture-python.myst publishes a different lecture as lln_clt, and
the lectures monorepo needs every name to be unique across the published
sites; the intro side takes the _intro suffix, as ruled on
QuantEcon/project-monorepo#75. The old address redirects to the new one
through a rediraffe_redirects entry. Part of QuantEcon/project-monorepo#76.
@mmcky
mmcky marked this pull request as ready for review October 9, 2026 05:20
Copilot AI balanced review requested due to automatic review settings October 9, 2026 05:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The rename is fully consistent — toc, redirect, and all five cross-references are updated, no stale references remain, and the unchanged external link and equation label are correctly out of scope.

0 open findings

What changed in this PR

This PR renames the intro series' lln_clt lecture to lln_clt_intro so that lecture names stay unique across QuantEcon's published sites (the lecture-python.myst series publishes a different lln_clt). It is part of a coordinated set of three intro renames (#855, #856, #857) and fits into the monorepo-wide uniqueness effort (QuantEcon/project-monorepo#76).

Changes:

  • Renamed lectures/lln_clt.md to lectures/lln_clt_intro.md and updated its _toc.yml entry.
  • Added lln_clt.md: lln_clt_intro.md under rediraffe_redirects in lectures/_config.yml so the old URL redirects.
  • Updated five {doc} cross-references across heavy_tails, markov_chains_II, monte_carlo, and observed_distributions.
File Description
lectures/​lln_clt_intro.md New file (renamed from lln_clt.md); content unchanged
lectures/​_toc.yml Toc entry updated to lln_clt_intro
lectures/​_config.yml Added rediraffe redirect from old name to new name
lectures/​heavy_tails.md Updated {doc} cross-reference to lln_clt_intro
lectures/​markov_chains_II.md Updated {doc} cross-reference to lln_clt_intro
lectures/​monte_carlo.md Updated {doc} cross-reference to lln_clt_intro
lectures/​observed_distributions.md Updated two {doc} cross-references to lln_clt_intro

I verified that no remaining {doc} link in the repo points at the old lln_clt target, the old file is gone and the new file exists, and the redirect/toc entries are consistent. The external link on line 31 (python.quantecon.org/lln_clt.html) correctly remains unchanged because it refers to a different (advanced) series' lecture, and the :label: lln_clt on line 439 is a pre-existing internal math-equation label, not a file reference.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mmcky
mmcky merged commit 4fb9454 into main Oct 9, 2026
6 of 8 checks passed
@mmcky
mmcky deleted the rename-lln_clt branch October 9, 2026 05:28
@mmcky

mmcky commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-intro.zh-cn
Translation PR: QuantEcon/lecture-intro.zh-cn#312
Files synced (6):

  • lectures/heavy_tails.md
  • lectures/markov_chains_II.md
  • lectures/monte_carlo.md
  • lectures/observed_distributions.md
  • lectures/lln_clt_intro.md
  • lectures/_toc.yml

mmcky added a commit to QuantEcon/lecture-intro.zh-cn that referenced this pull request Oct 9, 2026
As in #311: the sync mirrors the English _toc.yml, which lists four
lectures this edition has not translated (bivariate_dist, bayes_intro,
tax_smooth, msy_fishery). Drop those entries; the rename line stays.
Redirect the old address: lln_clt.md: lln_clt_intro.md, as in the
English series (QuantEcon/lecture-python-intro#856). The branch also
takes main, which #311 moved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mmcky added a commit to QuantEcon/lecture-intro.zh-cn that referenced this pull request Oct 9, 2026
… are unique across the published sites (#312)

* Update translation: lectures/heavy_tails.md

* Update translation: .translate/state/heavy_tails.md.yml

* Update translation: lectures/markov_chains_II.md

* Update translation: .translate/state/markov_chains_II.md.yml

* Update translation: lectures/monte_carlo.md

* Update translation: .translate/state/monte_carlo.md.yml

* Update translation: lectures/observed_distributions.md

* Update translation: .translate/state/observed_distributions.md.yml

* Update translation: lectures/lln_clt_intro.md

* Update translation: .translate/state/lln_clt_intro.md.yml

* Update translation: lectures/_toc.yml

* Delete removed file: lectures/lln_clt.md

* Delete removed file: .translate/state/lln_clt.md.yml

* Keep the edition's toc; add the lln_clt redirect

As in #311: the sync mirrors the English _toc.yml, which lists four
lectures this edition has not translated (bivariate_dist, bayes_intro,
tax_smooth, msy_fishery). Drop those entries; the rename line stays.
Redirect the old address: lln_clt.md: lln_clt_intro.md, as in the
English series (QuantEcon/lecture-python-intro#856). The branch also
takes main, which #311 moved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants