Skip to content

Rename lake_model to lake_model_intro so lecture names are unique across the published sites - #855

Merged
mmcky merged 1 commit into
mainfrom
rename-lake_model
Oct 9, 2026
Merged

mmcky merged 1 commit into
mainfrom
rename-lake_model

Conversation

@mmcky

@mmcky mmcky commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Part of QuantEcon/project-monorepo#76. QuantEcon/lecture-python.myst publishes a different lecture as lake_model, and the lectures monorepo needs every lecture name to be unique across the published sites. QuantEcon/project-monorepo#75 ruled that the intro side takes an _intro suffix.

What this changes

  • lectures/lake_model.md is renamed to lectures/lake_model_intro.md, and its _toc.yml entry follows it.
  • lectures/_config.yml gains lake_model.md: lake_model_intro.md under rediraffe_redirects, so the old address redirects to the new one.
  • No other lecture in the series links to it. No other series links to intro's lake_model by name; I checked all six.
  • Checked on the branch:
    • the redirect's old file is gone and its new file exists;
    • every _toc.yml entry has a file;
    • no {doc} link points at a missing file.

The translation hold is cleared: action-translation v0.29.4 (2026-10-09) carries QuantEcon/action-translation#291, and v0, which sync-translations-zh-cn.yml runs, now points at it. This PR is ready to merge.

🤖 Generated with Claude Code

…oss the sites

QuantEcon/lecture-python.myst publishes a different lecture as lake_model, and
the lectures monorepo needs every name to be unique across the published
sites; the intro side takes the _intro suffix, as ruled on
QuantEcon/project-monorepo#75. The old address redirects to the new one
through a rediraffe_redirects entry. Part of QuantEcon/project-monorepo#76.
@netlify

netlify Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit f08c7f6
🔍 Latest deploy log https://app.netlify.com/projects/taupe-gaufre-c4e660/deploys/6ac82093ff376200075a38c2
😎 Deploy Preview https://deploy-preview-855--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mmcky

mmcky commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

The red checks are expected.

What fails: the HTML build stops on one warning and nothing else: (broken) lake_model.html redirects to lake_model_intro.html but _build/html/lake_model.html already exists!.

Why: CI restores the build cache that cache.yml built from main. That cache still holds the old page, and rediraffe overwrites only the redirect pages it wrote itself. The other builds pass.

How it lands: each of the three intro PRs stays red until it is merged. After each merge:

  1. Run cache.yml on main.
  2. Push no publish* tag until that run is green.
  3. Then rebase the next PR.

This is on top of the hold for QuantEcon/action-translation#291.

@mmcky
mmcky marked this pull request as ready for review October 9, 2026 04:58
Copilot AI balanced review requested due to automatic review settings October 9, 2026 04:58
@mmcky
mmcky merged commit 9a25277 into main Oct 9, 2026
6 of 8 checks passed
@mmcky
mmcky deleted the rename-lake_model branch October 9, 2026 04:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

It is a self-contained, verified lecture rename with a correct redirect and no remaining in-repo references to the old name.

0 open findings

What changed in this PR

This PR renames the lake_model lecture to lake_model_intro so that lecture names are unique across QuantEcon's published sites (the intro series takes the _intro suffix per QuantEcon/project-monorepo#75). It is part of a coordinated set of three rename PRs (#855, #856, #857) and fits into the monorepo effort to disambiguate lecture names across editions.

Changes:

  • Renames lectures/lake_model.md to lectures/lake_model_intro.md (content unchanged) and updates its _toc.yml entry.
  • Adds a rediraffe_redirects entry (lake_model.md: lake_model_intro.md) in _config.yml so the old URL redirects to the new one.
File Description
lectures/​lake_model_intro.md Renamed lecture file; content is carried over unchanged from lake_model.md.
lectures/​_toc.yml Updates the table-of-contents entry to point at the new filename.
lectures/​_config.yml Adds a rediraffe redirect from the old path to the new path to preserve existing links.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mmcky

mmcky commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-intro.zh-cn
Translation PR: QuantEcon/lecture-intro.zh-cn#311
Files synced (2):

  • lectures/lake_model_intro.md
  • lectures/_toc.yml

mmcky added a commit to QuantEcon/lecture-intro.zh-cn that referenced this pull request Oct 9, 2026
The sync mirrors the English _toc.yml, which lists four lectures this
edition has not translated (bivariate_dist, bayes_intro, tax_smooth,
msy_fishery), so the build failed on four nonexistent documents. Drop
those entries, as the edition's toc already does; the rename line stays.
Also redirect the old address: lake_model.md: lake_model_intro.md, as
in the English series (QuantEcon/lecture-python-intro#855).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mmcky added a commit to QuantEcon/lecture-intro.zh-cn that referenced this pull request Oct 9, 2026
… names are unique across the published sites (#311)

* Update translation: lectures/lake_model_intro.md

* Update translation: .translate/state/lake_model_intro.md.yml

* Update translation: lectures/_toc.yml

* Delete removed file: lectures/lake_model.md

* Delete removed file: .translate/state/lake_model.md.yml

* Keep the edition's toc; add the lake_model redirect

The sync mirrors the English _toc.yml, which lists four lectures this
edition has not translated (bivariate_dist, bayes_intro, tax_smooth,
msy_fishery), so the build failed on four nonexistent documents. Drop
those entries, as the edition's toc already does; the rename line stays.
Also redirect the old address: lake_model.md: lake_model_intro.md, as
in the English series (QuantEcon/lecture-python-intro#855).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants