Repository navigation
🔒 Fix unquoted argument in Start-Process execution for OneDrive uninstaller - #59
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed unquoted argument vulnerability in
Start-Processexecution of$oneDriveUninstallerinunslop-win10.ps1andunslop-win11.ps1.Start-Process -FilePath $oneDriveUninstallerwithout explicit double quotes when$oneDriveUninstallercontains spaces (e.g., in user profile directories such asC:\Users\John Doe\AppData\...) could lead to parameter binding ambiguity or unquoted executable path vulnerabilities.🛡️ Solution: Wrapped
-FilePath "$oneDriveUninstaller"in explicit double quotes to guarantee safe string evaluation inStart-Processcalls and added AST invariant unit tests intests/unslop-win10.Tests.ps1andtests/unslop-win11.Tests.ps1.PR created automatically by Jules for task 3093022399951806543 started by @Ahmed-Yaseen99