Skip to content

🔒 Fix unquoted argument in Start-Process execution for OneDrive uninstaller - #59

Merged
Ahmed-Yaseen99 merged 1 commit into
mainfrom
fix-unquoted-start-process-onedrive-3093022399951806543
Oct 15, 2026
Merged

Ahmed-Yaseen99 merged 1 commit into
mainfrom
fix-unquoted-start-process-onedrive-3093022399951806543

Conversation

@Ahmed-Yaseen99

Copy link
Copy Markdown
Member

🎯 What: Fixed unquoted argument vulnerability in Start-Process execution of $oneDriveUninstaller in unslop-win10.ps1 and unslop-win11.ps1.

⚠️ Risk: Executing Start-Process -FilePath $oneDriveUninstaller without explicit double quotes when $oneDriveUninstaller contains spaces (e.g., in user profile directories such as C:\Users\John Doe\AppData\...) could lead to parameter binding ambiguity or unquoted executable path vulnerabilities.

🛡️ Solution: Wrapped -FilePath "$oneDriveUninstaller" in explicit double quotes to guarantee safe string evaluation in Start-Process calls and added AST invariant unit tests in tests/unslop-win10.Tests.ps1 and tests/unslop-win11.Tests.ps1.


PR created automatically by Jules for task 3093022399951806543 started by @Ahmed-Yaseen99

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Ahmed-Yaseen99
Ahmed-Yaseen99 merged commit 6d3be8f into main Oct 15, 2026
5 checks passed
@Ahmed-Yaseen99
Ahmed-Yaseen99 deleted the fix-unquoted-start-process-onedrive-3093022399951806543 branch October 15, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant