Repository navigation
🔒 Quote Start-Process -FilePath for OneDrive uninstaller - #53
Ahmed-Yaseen99 wants to merge 1 commit into
Conversation
Enclose $oneDriveUninstaller in double quotes when passed to Start-Process -FilePath in unslop-win11.ps1 and unslop-win10.ps1. This ensures file paths containing whitespace (e.g. AppData user paths) are bound as a single string argument.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Superseded by #59, which incorporates the identical Start-Process FilePath quoting alongside mandatory AST invariant unit tests in compliance with repository testing standards. |
🎯 What: Quoted
-FilePath "$oneDriveUninstaller"inunslop-win11.ps1andunslop-win10.ps1.Start-Process -FilePath $oneDriveUninstaller, paths containing whitespace (such as user AppData directories likeC:\Users\User Name\AppData\...) could cause argument parsing issues or unexpected binary path resolution.🛡️ Solution: Explicitly quoted
"$oneDriveUninstaller"inStart-Processinvocations across both scripts, ensuring the path parameter is safely bounded.PR created automatically by Jules for task 930741032652600173 started by @Ahmed-Yaseen99