Remove ACA-Py - #72
Merged
bzp99 merged 4 commits intoJul 29, 2026
Merged
Conversation
This was referenced Jul 27, 2026
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated dva-acapy-controller component and associated ACA-Py wiring from the repository, while cleaning up the dva-api codepaths that previously stored and exposed ACA-Py verification request logs.
Changes:
- Remove the
dva-acapy-controllermodule and its Docker/test-environment wiring (compose services, shared service definitions, test data, docs). - Drop
VerifRequestLog*model/repo + Postgres mapping/repo wiring fromdva-api(including DB table creation and Koin bindings). - Simplify
/infoAPI resources/routes to only expose request logs.
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test-env/test-data/aov/verif-req.json | Removed AoV verification request sample JSON. |
| test-env/test-data/aca-py-controller-aov-req.json | Removed ACA-Py controller AoV request sample JSON. |
| test-env/test-data/aca-py-controller-aov-pres-req.json | Removed ACA-Py controller presentation request sample JSON. |
| test-env/compose.yml | Removed ACA-Py agent/controller services and related env vars/depends_on. |
| test-env/common-services.yml | Removed common service templates for aca-py and dva-aca-py-controller. |
| README.md | Removed ACA-Py component references and adjusted docs around /attestation/verify. |
| dva-api/model/src/main/kotlin/hu/bme/mit/ftsrg/dva/log/VerifRequestLogRepo.kt | Deleted VerifRequestLogRepo interface. |
| dva-api/model/src/main/kotlin/hu/bme/mit/ftsrg/dva/log/VerifRequestLog.kt | Deleted VerifRequestLog* DTO/model types. |
| dva-api/model/src/main/kotlin/hu/bme/mit/ftsrg/dva/log/FakeVerifRequestLogRepo.kt | Deleted fake in-memory verification log repo. |
| dva-api/api/src/test/kotlin/hu/bme/mit/ftsrg/dva/api/route/AoVRoutesTest.kt | Removed VerifRequestLogRepo wiring from test DI setup. |
| dva-api/api/src/main/kotlin/hu/bme/mit/ftsrg/dva/api/route/infoRoutes.kt | Removed /info/presentations and /info/credentials routes. |
| dva-api/api/src/main/kotlin/hu/bme/mit/ftsrg/dva/api/route/aovRoutes.kt | Removed verification-log persistence around /attestation/verify. |
| dva-api/api/src/main/kotlin/hu/bme/mit/ftsrg/dva/api/resource/Info.kt | Removed Info.Presentations and Info.Credentials resources. |
| dva-api/api/src/main/kotlin/hu/bme/mit/ftsrg/dva/api/db/verifRequestLogMapping.kt | Deleted Exposed mapping for verification_request_logs table. |
| dva-api/api/src/main/kotlin/hu/bme/mit/ftsrg/dva/api/db/PgVerifRequestLogRepo.kt | Deleted Postgres implementation of VerifRequestLogRepo. |
| dva-api/api/src/main/kotlin/hu/bme/mit/ftsrg/dva/api/db/databases.kt | Removed VerifRequestLogsTable from schema creation. |
| dva-api/api/src/main/kotlin/hu/bme/mit/ftsrg/dva/api/Application.kt | Removed Koin binding for VerifRequestLogRepo. |
| dva-acapy-controller/uv.lock | Deleted uv lockfile for removed controller module. |
| dva-acapy-controller/tests/test_controller.py | Deleted controller module tests. |
| dva-acapy-controller/static/index.html | Deleted controller static UI. |
| dva-acapy-controller/src/dva_acapy_controller/controller.py | Deleted controller implementation. |
| dva-acapy-controller/src/dva_acapy_controller/config.py | Deleted controller config module. |
| dva-acapy-controller/README.md | Deleted controller module README. |
| dva-acapy-controller/pyproject.toml | Deleted controller module project config. |
| dva-acapy-controller/LICENSE | Deleted controller module license file. |
| dva-acapy-controller/Dockerfile | Deleted controller module Dockerfile. |
| dva-acapy-controller/.python-version | Deleted controller module Python version file. |
| dva-acapy-controller/.gitignore | Deleted controller module gitignore. |
| dva-acapy-controller/.dockerignore | Deleted controller module dockerignore. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
6
to
11
| @Resource("/info") | ||
| class Info { | ||
|
|
||
| @Resource("requests") | ||
| class Requests(val parent: Info = Info()) | ||
|
|
||
| @Resource("presentations") | ||
| class Presentations(val parent: Info = Info()) | ||
|
|
||
| @Resource("credentials") | ||
| class Credentials(val parent: Info = Info()) | ||
| } |
Collaborator
There was a problem hiding this comment.
Our friend is right here, I'd immediately patch the karate tests, too.
UPDATE: opted to disable all attestation-related tests in b5633d8 for now
bzp99
reviewed
Jul 29, 2026
bzp99
left a comment
bzp99
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall, I’ll go ahead and resolve my and Copilot’s comments, make a sweep to see if there are no traces of ACA-Py left and then we can merge.
Comment on lines
6
to
11
| @Resource("/info") | ||
| class Info { | ||
|
|
||
| @Resource("requests") | ||
| class Requests(val parent: Info = Info()) | ||
|
|
||
| @Resource("presentations") | ||
| class Presentations(val parent: Info = Info()) | ||
|
|
||
| @Resource("credentials") | ||
| class Credentials(val parent: Info = Info()) | ||
| } |
Collaborator
There was a problem hiding this comment.
Our friend is right here, I'd immediately patch the karate tests, too.
UPDATE: opted to disable all attestation-related tests in b5633d8 for now
bzp99
force-pushed
the
chore/remove-acapy
branch
3 times, most recently
from
July 29, 2026 21:19
e8a1786 to
42e4276
Compare
BREAKING CHANGE: removes ACA-Py entirely in an effort to switch VC standards and the entire credential handling system
bzp99
force-pushed
the
chore/remove-acapy
branch
from
July 29, 2026 21:22
42e4276 to
bd09c72
Compare
bzp99
merged commit Jul 29, 2026
bd09c72
into
Prometheus-X-association:yassine-refactor
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated ACA-Py controller service and its coupling from the dva-api module:
dva-acapy-controller, its compose services, env vars and leftover test dataVerifRequestLogchain frominfoRoutesandaovRoutes(now backed only byReqestLogRepo):api:compileTestKotlincleanFollow-up
fix(dva-api): drop residual VerifRequestLog refspatch completes the cleanup inaovRoutes.ktandAoVRoutesTest.ktleft over from the initial removal commit.Depends on: none
@bzp99