Skip to content

Make attestation and verification synchronous - #76

Open
MYRhouma wants to merge 5 commits into
Prometheus-X-association:yassine-refactorfrom
MYRhouma:feat/dva-api-attestation
Open

Make attestation and verification synchronous#76
MYRhouma wants to merge 5 commits into
Prometheus-X-association:yassine-refactorfrom
MYRhouma:feat/dva-api-attestation

Conversation

@MYRhouma

Copy link
Copy Markdown
Contributor

Replaces the previous async RabbitMQ-backed attestation flow with a synchronous POST /attestation that returns the AoV JWS inline and a POST /attestation/verify that delegates to dva-vc-manager.

  • /attestation validates vlaId (UUID parse), fetches the VLA from vla-manager-api, batches evaluation against dva-processing, and on success asks dva-vc-manager to issue the JWS; on failure returns 200 with evaluationPassing=false and jws=null
  • /attestation/verify forwards the JWS to dva-vc-manager
  • dataProvider is used as the VC subject (falls back to attesterID)
  • OpenAPI spec updated
  • AoVSyncRoutesTest (4 unit tests) covers pass/fail issue and verified true/false verify paths using a MockEngine-backed HttpClient; ktor-client-mock dependency added
  • obsolete async AoVRoutesTest.kt removed (superseded by AoVSyncRoutesTest.kt)

Depends on: #72 (ACA-Py removal), #73 (dva-vc-manager), #74 (vla-manager-api), #75 (slim dva-api-processing)

@bzp99

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bzp99 bzp99 self-assigned this Jul 29, 2026
@bzp99 bzp99 changed the title feat(dva-api): synchronous attestation and verify endpoints Make attestation and verification synchronous Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants