Skip to content

bug: #258 jsx shadow root detection using wrong source input contents #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thescientist13 merged 2 commits into from
Jun 27, 2026
Merged

bug: #258 jsx shadow root detection using wrong source input contents #276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22b2c11
bug: #258 fix naive jsx shadow root detection check
thescientist13 Jun 11, 2026
be5e586
chore: #258 add comments
thescientist13 Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/jsx-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ export function parseJsx(moduleURL) {
// TODO: (good first issue) find a more AST (visitor) based way to check for this
// https://github.com/ProjectEvergreen/wcc/issues/258
hasShadowRoot =
moduleContents.slice(node.body.start, node.body.end).indexOf('this.attachShadow(') > 0;
result.code.slice(node.body.start, node.body.end).indexOf('this.attachShadow(') > 0;

for (const n1 of node.body.body) {
if (n1.type === 'MethodDefinition') {
Expand Down Expand Up @@ -773,6 +773,7 @@ export function parseJsx(moduleURL) {
) {
// TODO: do we even need this filter?
const trackingAttrs = observedAttributes.filter((attr) => typeof attr === 'string');
// create a disconnectedCallback function if not present to append effect cleanup functions
const disconnectedCallbackContents = hasDisconnectedCallback
? ''
: `
Expand Down Expand Up @@ -816,13 +817,13 @@ export function parseJsx(moduleURL) {
}
},
MethodDefinition(node) {
// append DOM references and effect functions for signals
if (node.key.name === 'connectedCallback') {
const root = hasShadowRoot ? 'this.shadowRoot' : 'this';
const effectElements = reactiveElements
.map((el, idx) => `this.$el${idx} = ${root}.querySelector('${el.selector}');`)
.join('\n');
const effectContents = generateEffectsForReactiveElements(reactiveElements);

const effectElementsTree = acorn.parse(effectElements, acornParseOptions);
const effectContentsTree = acorn.parse(effectContents, acornParseOptions);

Expand All @@ -833,6 +834,7 @@ export function parseJsx(moduleURL) {
];
}

// append cleanup functions.if component already has a disconnectedCallback
if (node.key.name === 'disconnectedCallback' && hasDisconnectedCallback) {
const effectCleanupContents =
generateEffectsCleanupForReactiveElements(reactiveElements);
Expand Down