Skip to content

bug: #258 jsx shadow root detection using wrong source input contents#276

Merged
thescientist13 merged 2 commits into
masterfrom
bug/issue-258-jsx-shadow-root-detection-miss
Jun 27, 2026
Merged

bug: #258 jsx shadow root detection using wrong source input contents#276
thescientist13 merged 2 commits into
masterfrom
bug/issue-258-jsx-shadow-root-detection-miss

Conversation

@thescientist13

@thescientist13 thescientist13 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Related Issue

related to (but doesn't resolve) #258


Observed in AnalogStudiosRI/www.analogstudios.net#112 that we were not getting a Shadow Root out of a component that was using attachShadow, which was then causing it to not render

Screenshot 2026-06-11 at 9 09 20 AM Screenshot 2026-06-11 at 9 09 39 AM

Summary of Changes

  1. Have shadow root check against source input being walked over (not the initial module contents)

@thescientist13 thescientist13 added this to the 1.0 milestone Jun 11, 2026
@thescientist13 thescientist13 self-assigned this Jun 11, 2026
@thescientist13 thescientist13 added bug Something isn't working JSX labels Jun 11, 2026
@thescientist13 thescientist13 changed the title bug: #258 fix naive jsx shadow root detection check bug: #258 jsx shadow root detection using wrong source contents Jun 11, 2026
@thescientist13 thescientist13 moved this to 👀 In review in [WCC] General Activities Jun 11, 2026
@thescientist13 thescientist13 changed the title bug: #258 jsx shadow root detection using wrong source contents bug: #258 jsx shadow root detection using wrong source input contents Jun 11, 2026
@thescientist13 thescientist13 merged commit 768461d into master Jun 27, 2026
17 checks passed
@thescientist13 thescientist13 deleted the bug/issue-258-jsx-shadow-root-detection-miss branch June 27, 2026 14:17
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in [WCC] General Activities Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.22.1 bug Something isn't working JSX

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

find more idiomatic way to detect attachShadow usage in the JSX compiler

1 participant