Skip to content

fix(ci): tell gh which repository to upload the signatures to #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MotherSphere merged 1 commit into from
Aug 1, 2026
Merged

fix(ci): tell gh which repository to upload the signatures to #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,10 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
TAG: ${{ needs.release-please.outputs.tag_name }}
run: gh release upload "$TAG" dist/*.sig --clobber
# -R is not optional here. This job has no `actions/checkout`, so there
# is no git repository for `gh` to infer the target from, and it dies
# with "not a git repository" AFTER the assets have been signed. The
# download step above already passes it; this one was missed, and the
# release shipped unsigned while the job that was meant to prevent
# exactly that reported the failure too late to stop it.
run: gh release upload "$TAG" -R "${{ github.repository }}" dist/*.sig --clobber
Loading